Skip to content
This repository has been archived by the owner on Oct 24, 2020. It is now read-only.

Implement PSR-3 #28

Open
danaki opened this issue Apr 15, 2017 · 1 comment
Open

Implement PSR-3 #28

danaki opened this issue Apr 15, 2017 · 1 comment

Comments

@danaki
Copy link

danaki commented Apr 15, 2017

Please log using standard PSR-3, instead of error_log, thus a logger can be injected into objects.

@josecelano
Copy link
Contributor

Thanks @danaki that's a good idea. I have to think how to add that change without breaking backward compatibility. I think we could add an ApiContext->setLogger(LoggerInterface ...)method to add an extra logger. That logger could be called in all places where we currently use BlockCypherLoggingManager. We can not totally replace that one becuase I think it's very useful to have a out-of-the-box logger without defining you own logger. We should also implement LoggerInterface in BlockCypherLoggingManager.

Anyway I do not have too much free time to do it rigth now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants