Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cert tools should warn or error when missing config info will result in invalid cert #32

Open
stuartf opened this issue Sep 25, 2018 · 1 comment

Comments

@stuartf
Copy link
Contributor

stuartf commented Sep 25, 2018

I created a cert with no revocation_list in the conf.ini this resulted in the cert having revocation_list: null which cannot be imported to the iOS wallet. The tool shouldn't output broken certs.

@ghost
Copy link

ghost commented Feb 6, 2019

The Cert Tools already give a warn to a few parameters:

create-certificate-template: error: the following arguments are required: --issuer_name, --issuer_id, --certificate_title, --criteria_narrative, --badge_id

Yout can add the parameter revocation_list to the list of required parameters and make a pull.

How exactly did you generate your conf.ini, I'm trying to generate one and I receive TypeError: join() argument must be str or bytes, not 'NoneType':

create-certificate-template -c '/home/pc/Documents/Block/conf.ini' --issuer_email '[email protected]' --issuer_name 'name' --issuer_id 'id' --certificate_title 'title', --criteria_narrative 'criteria' --badge_id 'badge id'

I have fixed it, this module don't support Python 3.7, the function generic_path (/lib/python3.5/genericpath.py) can't get the parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant