Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute #25

Closed
FaganSC opened this issue May 14, 2020 · 3 comments
Closed

Contribute #25

FaganSC opened this issue May 14, 2020 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@FaganSC
Copy link

FaganSC commented May 14, 2020

I'd happy to contribute. I have been working on a similar module but using Certificates for seamless authentication.

@blindzero
Copy link
Owner

blindzero commented May 14, 2020

Hi @FaganSC,

glad to hear that! I already noticed your Fork, nice.
Do you want to contribute with code? I am glad to receive your PR, e.g. if you want to add certificate support for authentication. As far as I've seen it, certificate authentication is only available for AzureAD / Azure?

BTW: I have to write the Contribute page I think ;)

Best,
Matthias

@blindzero blindzero self-assigned this May 14, 2020
@blindzero blindzero added the question Further information is requested label May 14, 2020
@FaganSC
Copy link
Author

FaganSC commented May 14, 2020

Yea that would be helpful to write the contribute page. I haven't worked with the build and testing process your using so a little help getting setup would be great.

I have successfully setup several of the modules to connect using my setup with certificates and would be happy to add to your module.

@blindzero blindzero added the documentation Improvements or additions to documentation label May 15, 2020
blindzero added a commit that referenced this issue May 15, 2020
@blindzero
Copy link
Owner

Hi @FaganSC
I added the CONTRIBUTE documentation, do you want to have a look?
About certificate authentication: do you want to create a separate feature request for it?
Is it just available for Azure of for all services? Does it should be linked to #23 (user configuration file)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants