Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delay to kill stream script #423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add delay to kill stream script #423

wants to merge 1 commit into from

Conversation

noamokman
Copy link

@noamokman noamokman commented May 3, 2024 •
edited
Loading

Hey,
I added the ability to delay termination so that users can have enough time to see the transcode reason before termination
Thanks!

guysegal
guysegal approved these changes May 3, 2024
View reviewed changes
Copy link

@guysegal guysegal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

C0nw0nk
C0nw0nk approved these changes Jul 31, 2024
View reviewed changes
Copy link

@C0nw0nk C0nw0nk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed tested and working fine.

Kill stream messages do infact display upon delay before they would just terminate with no message / reasons provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SharonGrossman SharonGrossman SharonGrossman approved these changes

@C0nw0nk C0nw0nk C0nw0nk approved these changes

@guysegal guysegal guysegal approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noamokman @guysegal @C0nw0nk @SharonGrossman