Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving design #4

Open
bjorno43 opened this issue Oct 4, 2020 · 3 comments
Open

Improving design #4

bjorno43 opened this issue Oct 4, 2020 · 3 comments
Labels
enhancement New feature or request hacktoberfest

Comments

@bjorno43
Copy link
Owner

bjorno43 commented Oct 4, 2020

The overall design of the program can be improved in a number of ways. The most wanted feature for me as a Dark and Light mode that users can switch to. But this is a very open enhancement request. If you'd like to take upon you, you'll have a lot of freedom if using your own imagination and come up with nice ideas!

@bjorno43 bjorno43 added enhancement New feature or request hacktoberfest labels Oct 4, 2020
@maratmuginov
Copy link
Contributor

I suggest a move to WPF early on in the project. XAML will allow us unlimited customization, and its built in support for MVVM will allow for the proper separation of concerns and unit testing.

@bjorno43
Copy link
Owner Author

bjorno43 commented Oct 21, 2020

@maratmuginov Although I have no issue with moving to WPF, there were a few problems with using that in this project. Can't really recall the actual issue, but it had to do with the file browsers not being supported in WPF in that the way they're being used in this project. That's why I decided not to do it when I started working on this.

But you're more than welcome to have a look at this. If you can get to work, I'm definitely interested!

@maratmuginov
Copy link
Contributor

@bjorno43 I am familiar with the issue of file browsers in WPF. There are four possible solutions -

  1. Microsoft.Win32 managed namespace provides access to the SaveFile / OpenFIle dialogs only.
  2. Referencing System.Windows.Forms and using its dialogs.
  3. Hooking into Windows.SDK.Contracts and using UWP dialogs.
  4. Windows API CodePack Shell - an extension to Win32 dialogs that allows us a OpenFileDialog style for folder picking (.NET Framework only).

If this was the only issue with WPF, we can pick one of these solutions and move to WPF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants