Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bignum: fix hard-coded radix in toBits(), remove broken Math.min #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stbuehler
Copy link
Contributor

  • fix hard-coded radix in toBits(): need to round up len first if radix isn't byte aligned, which makes it also more readable
  • remove broken Math.min (which luckily never triggered) - only the first limb is possibly stored partial, all other limbs are stored with their full "radix" size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant