Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic wasm error alternative #1130

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented Oct 11, 2024

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ a80d6cba-8d66-4c0a-9d62-6d39fab0cc08

Fixed Issues

Severity Issue Source File / Package
MEDIUM Privacy_Violation /languages/go/example/example.go: 103

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 58.13%. Comparing base (5ee793a) to head (8f1ba7c).
Report is 1 commits behind head on PM-11764-implement-account-switching-and-sdk-initialization.

Files with missing lines Patch % Lines
crates/bitwarden-wasm-internal/src/error.rs 0.00% 4 Missing โš ๏ธ
crates/bitwarden-wasm-internal/src/crypto.rs 0.00% 2 Missing โš ๏ธ
Additional details and impacted files
@@                                       Coverage Diff                                       @@
##           PM-11764-implement-account-switching-and-sdk-initialization    #1130      +/-   ##
===============================================================================================
+ Coverage                                                        58.11%   58.13%   +0.02%     
===============================================================================================
  Files                                                              197      197              
  Lines                                                            13600    13595       -5     
===============================================================================================
  Hits                                                              7904     7904              
+ Misses                                                            5696     5691       -5     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@coroiu coroiu requested a review from Hinton October 11, 2024 12:21
@coroiu coroiu merged commit 3c24ae7 into PM-11764-implement-account-switching-and-sdk-initialization Oct 14, 2024
92 of 99 checks passed
@coroiu coroiu deleted the ps/generic-wasm-error-alternative branch October 14, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant