Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRE-341 - Update Publish PHP workflow #1074

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

vgrassia
Copy link
Member

🎟️ Tracking

📔 Objective

This PR updates the Publish PHP workflow to allow releasing from the main branch instead of the rc branches.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vgrassia vgrassia self-assigned this Sep 23, 2024
@vgrassia vgrassia requested a review from a team as a code owner September 23, 2024 13:47
@vgrassia vgrassia enabled auto-merge (squash) September 23, 2024 13:47
@vgrassia vgrassia merged commit 56fc75d into main Sep 23, 2024
76 checks passed
@vgrassia vgrassia deleted the bre-341_update-php-workflows branch September 23, 2024 13:48
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details91db520a-3014-4b0b-bdae-83f3731e6216

No New Or Fixed Issues Found

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.11%. Comparing base (7ff270d) to head (0b7715f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1074   +/-   ##
=======================================
  Coverage   58.11%   58.11%           
=======================================
  Files         197      197           
  Lines       13531    13531           
=======================================
  Hits         7864     7864           
  Misses       5667     5667           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants