Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12751] Added home to plugs to allow access to home directory #11281

Closed
wants to merge 1 commit into from

Conversation

tingdahl
Copy link

@tingdahl tingdahl commented Sep 27, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12751
#11280.

πŸ“” Objective

Fix #11280. The bw snap cannot read/write to disk as it does not have
the home directory access enabled in its confinement.

https://snapcraft.io/docs/home-interface

Note that I don't have the machinery to test the solution, so this PR is to point you in the right direction of fixing the issue.

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2024

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-12751

@bitwarden-bot bitwarden-bot changed the title Added home to plugs to allow access to home directory [PM-12751] Added home to plugs to allow access to home directory Sep 27, 2024
@quexten quexten self-assigned this Sep 27, 2024
Copy link
Contributor

@quexten quexten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thank you for the PR! I'll create a branch for QA to test. The home plug seems to have been erroneously removed in #3596

@quexten
Copy link
Contributor

quexten commented Oct 25, 2024

@tingdahl Thank you for the PR. We've decided to go ahead and merge this older PR: #5577 which introduces the same home permission and also removable-media. Closing this PR now, thank you again for the contribution.

@quexten quexten closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bw snap does not allow storing local files
4 participants