Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11780] Resolve TypeScript 5.3 compile error #11215

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented Sep 24, 2024

📔 Objective

Tweaks code to compile on TS 5.3. @cagonzalezcs I believe you added this code, could you take a look that it still does what it's supposed to?

Tip: You can play around with the typings here TypeScript Playground

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@coroiu coroiu requested a review from a team as a code owner September 24, 2024 11:30
@coroiu coroiu force-pushed the PM-11780-resolve-type-script-5-3-compile-error branch from d477fea to 4579541 Compare September 24, 2024 11:31
Copy link
Contributor

github-actions bot commented Sep 24, 2024

Logo
Checkmarx One – Scan Summary & Details0a01c092-87f6-4f3e-981f-3b355a27d205

No New Or Fixed Issues Found

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.07%. Comparing base (6484460) to head (4579541).
Report is 105 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...r/browser-api.register-content-scripts-polyfill.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #11215    +/-   ##
========================================
  Coverage   35.07%   35.07%            
========================================
  Files        2710     2718     +8     
  Lines       84542    84836   +294     
  Branches    16064    16135    +71     
========================================
+ Hits        29653    29759   +106     
- Misses      53918    54099   +181     
- Partials      971      978     +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cagonzalezcs cagonzalezcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code handles dynamically setting the content scripts for FIDO2 behavior based on the user's setting.

I pulled the code down, ran a build for Mv2 (which is affected by this change), and tested that passkeys can be enabled/disabled dynamically as expected.

Everything looks good from my side.

@coroiu coroiu added needs-qa Marks a PR as requiring QA approval and removed needs-qa Marks a PR as requiring QA approval labels Sep 25, 2024
@coroiu coroiu merged commit 0846c2c into main Oct 1, 2024
28 of 30 checks passed
@coroiu coroiu deleted the PM-11780-resolve-type-script-5-3-compile-error branch October 1, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants