Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate IPC messages #265

Open
grctest opened this issue Aug 30, 2023 · 0 comments
Open

Validate IPC messages #265

grctest opened this issue Aug 30, 2023 · 0 comments

Comments

@grctest
Copy link
Contributor

grctest commented Aug 30, 2023

Is your feature request related to a problem? Please describe.

Electron best practices talk about implementing validation of IPC messages, however they do not provide a standardised method of doing so.

It's possible that an advanced XSS could trigger IPC invocations, so checking that they were triggered from the right location and appropriately would further harden security from theoretical attacks.

Describe the solution you'd like

Upon IPC main invocation (from ipcrenderer invoke to ipcmain handle), verify that the request is legitimate.

Describe alternatives you've considered

Take additional steps to harden app to theoretical XSS, reducing need for IPC message validation.

Additional context

Related electron issue: electron/electron#33517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant