Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to different hashing library #1878

Closed
paulmillr opened this issue Feb 17, 2023 · 2 comments
Closed

Upgrade to different hashing library #1878

paulmillr opened this issue Feb 17, 2023 · 2 comments

Comments

@paulmillr
Copy link
Contributor

paulmillr commented Feb 17, 2023 •
edited
Loading

Continuing discussion in #1781. I suggest to replace those:

"create-hash": "^1.1.0",
"ripemd160": "^2.0.2",

With audited noble-hashes. Would you merge the PR if everything is smooth?

create-hash is at least 5 dependencies: https://bundlephobia.com/package/[email protected]
@junderw
Copy link
Member

junderw commented Feb 17, 2023

I've already personally audited noble-hashes with the merge into bip32, I would be fine merging it here too.

@paulmillr
Copy link
Contributor Author

gh-1879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulmillr @junderw