Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add missed icon file to resources #425

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Oct 12, 2024

This PR fixes build on macOS 13 x86_64:

RCC: Error in 'qml/bitcoin_qml.qrc': Cannot find file 'res/icons/minus.png'

@hebasto hebasto changed the title Add missed icon file to resources build: Add missed icon file to resources Oct 12, 2024
@hebasto hebasto mentioned this pull request Oct 12, 2024
@hebasto
Copy link
Member Author

hebasto commented Oct 12, 2024

cc @jarolrod

Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6138805

Copy link
Contributor

@johnny9 johnny9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6138805

Copy link
Contributor

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 6138805

@hebasto hebasto merged commit 88ce525 into bitcoin-core:main Oct 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants