Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast string var as str. #180

Closed
wants to merge 1 commit into from
Closed

Cast string var as str. #180

wants to merge 1 commit into from

Conversation

hrshdhgd
Copy link
Contributor

@hrshdhgd hrshdhgd commented Apr 9, 2024

Fixes #179

@cthoyt
Copy link
Member

cthoyt commented Apr 9, 2024

This doesn't make sense - since we're loading data through a pandas dataframe, these are actually NaN types and should definitely not be stringified

@cthoyt cthoyt closed this Apr 9, 2024
@hrshdhgd
Copy link
Contributor Author

hrshdhgd commented Apr 9, 2024 •
edited
Loading

Can you confirm that the code I mentioned in the issue runs for you? I am using the latest version of pyobo. Maybe pyobo needs a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error while trying to write ncbigene.obo via pyobo
2 participants
@hrshdhgd @cthoyt