-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 JSONC Not supported? #364
Comments
Thank you for the report, can you provide a reproduction? To create a reproduction, you can use our new CLI tool, which should help you to create a very quick repository with what you need: |
Hmm, I'm not able to repro even in my main project today. I wonder if it's because I changed my |
I encountered a similar issue; however, it only causes some inconvenience when using the Biome extension for the first time. Steps to Reproduce:
Although this displays as a popup instead of a notification, I believe it's related based on logs provided in this issue, as they suggest that the Biome extension fails to start due to a missing binary. Instead of stopping, it might be more helpful if a notification could inform users that the binary or package is missing when they attempt to format, rather than just at start-up. |
As far as I know this isn't possible because the LSP session needs to have been started for Biome to be registered as a formater. |
I just encountered another similar issue. When I open my This also happens with files opened using "Preferences: Open Workspace Settings (JSON)". However, Biome works fine when using "Preferences: Open Workspace Settings (JSON)", "File: Open File...", and most other methods. I'm on Windows if that helps. |
VS Code version
1.93.1
Extension version
v2024.9.200949 (pre-release)
Biome version
♺
Operating system
Description
Steps to reproduce
Open
settings.json
that has comments on some linesExpected behavior
The extension should not complain about "JSON with Comments"
Does this issue occur when using the CLI directly?
No
Link to a minimal reproduction
No response
Logs
The text was updated successfully, but these errors were encountered: