Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example notebooks and documentation #593

Merged
merged 6 commits into from
May 8, 2024
Merged

Example notebooks and documentation #593

merged 6 commits into from
May 8, 2024

Conversation

esgomezm
Copy link
Contributor

@esgomezm esgomezm commented May 7, 2024

No description provided.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 7, 2024
@esgomezm
Copy link
Contributor Author

esgomezm commented May 7, 2024

@FynnBe here is the new notebook and the doc updated but all the test to the PR fail and I really don't know why

@FynnBe
Copy link
Member

FynnBe commented May 7, 2024

@FynnBe here is the new notebook and the doc updated but all the test to the PR fail and I really don't know why

test failiure was unrelated and hopefully fixed now

Copy link
Member

@FynnBe FynnBe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't review in detail now... just one minor file too many ;-)

.DS_Store Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file shouldn't be here?

@esgomezm esgomezm merged commit 3c03386 into main May 8, 2024
8 checks passed
@esgomezm esgomezm deleted the esgomezm-patch2 branch May 8, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants