Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul with Pydantic and format version generic 0.3 / model 0.5 #521

Merged
merged 440 commits into from
Mar 9, 2024

Conversation

FynnBe
Copy link
Member

@FynnBe FynnBe commented Jul 27, 2023

No description provided.

@FynnBe FynnBe requested review from emilmelnikov and k-dominik and removed request for k-dominik July 27, 2023 12:34
@github-actions github-actions bot added ci Continuous Integration documentation Improvements or additions to documentation github_actions Pull requests that update Github_actions code labels Jul 27, 2023
@FynnBe FynnBe mentioned this pull request Aug 15, 2023
@oeway
Copy link
Contributor

oeway commented Aug 15, 2023

FYI, I created an ImJoy plugin for react json schema form: https://oeway.github.io/imjoy-json-schema-form/ we can use it in Jupyter notebooks or the model zoo website. Try it at https://jupyter.imjoy.io Useful for generating model yaml, e.g. for the model builder.

@FynnBe
Copy link
Member Author

FynnBe commented Aug 15, 2023

FYI, I created an ImJoy plugin for react json schema form: https://oeway.github.io/imjoy-json-schema-form/ we can use it in Jupyter notebooks or the model zoo website. Try it at https://jupyter.imjoy.io Useful for generating model yaml, e.g. for the model builder.

I tried it out: test.ipynb.txt
But maybe the current json schema is simply too big...
edit: log is full of "Could not find a definition for #/$defs/bioimageio__spec__application__v0_2__Application." etc..
seems like the defs are not supported or there is some other compatiblity issue with the json schema?
I get a white pop up window only:
image

@oeway
Copy link
Contributor

oeway commented Aug 15, 2023

I also got the same issue:

react-dom.production.min.js:189 Error: Could not find a definition for #/$defs/bioimageio__spec__application__v0_2__Application.
    at M (utils.js:614:9)
    at z (utils.js:693:20)
    at q (utils.js:681:12)
    at B (utils.js:704:24)
    at S (SchemaField.js:279:27)
    at t.value (SchemaField.js:433:14)
    at Ts (react-dom.production.min.js:204:189)
    at As (react-dom.production.min.js:203:149)
    at Ec (react-dom.production.min.js:292:172)
    at wu (react-dom.production.min.js:280:389)
ps @ react-dom.production.min.js:189
r.callback @ react-dom.production.min.js:189
qo @ react-dom.production.min.js:144
kc @ react-dom.production.min.js:262
wc @ react-dom.production.min.js:260
bc @ react-dom.production.min.js:259
(anonymous) @ react-dom.production.min.js:283
xu @ react-dom.production.min.js:281
iu @ react-dom.production.min.js:270
k @ scheduler.production.min.js:13
T @ scheduler.production.min.js:14
utils.js:614 Uncaught Error: Could not find a definition for #/$defs/bioimageio__spec__application__v0_2__Application.
    at M (utils.js:614:9)
    at z (utils.js:693:20)
    at q (utils.js:681:12)
    at B (utils.js:704:24)
    at S (SchemaField.js:279:27)
    at t.value (SchemaField.js:433:14)
    at Ts (react-dom.production.min.js:204:189)
    at As (react-dom.production.min.js:203:149)
    at Ec (react-dom.production.min.js:292:172)
    at wu (react-dom.production.min.js:280:389)

Removing all the discriminator eliminated the error, however, it still complaining about the root. You can also test it with the official page here: https://rjsf-team.github.io/react-jsonschema-form/

@FynnBe
Copy link
Member Author

FynnBe commented Aug 15, 2023

You can also test it with the official page here: https://rjsf-team.github.io/react-jsonschema-form/

there it works just fine
image

@FynnBe FynnBe marked this pull request as ready for review August 16, 2023 12:25
@FynnBe
Copy link
Member Author

FynnBe commented Oct 17, 2023

@FynnBe FynnBe merged commit 3c49c25 into main Mar 9, 2024
8 checks passed
@FynnBe FynnBe deleted the pydantic_axes branch March 9, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration documentation Improvements or additions to documentation github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants