Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bioimage.yaml in "required file" text to "rdf.yaml" #32

Closed
jmetz opened this issue Feb 6, 2024 · 8 comments · Fixed by #35
Closed

Rename bioimage.yaml in "required file" text to "rdf.yaml" #32

jmetz opened this issue Feb 6, 2024 · 8 comments · Fixed by #35
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@jmetz
Copy link
Collaborator

jmetz commented Feb 6, 2024

As decision on this renaming was to stick with original for now.

@jmetz jmetz added the bug Something isn't working label Feb 6, 2024
@jmetz jmetz self-assigned this Feb 6, 2024
@FynnBe
Copy link
Member

FynnBe commented Feb 6, 2024

Wasn't the consensus to switch to bioimageio.yaml??

@jmetz
Copy link
Collaborator Author

jmetz commented Feb 6, 2024

😅 @oeway asked me to switch it back... I'll let you two discuss 🫣

@jmetz jmetz added the question Further information is requested label Feb 6, 2024
@oeway
Copy link
Contributor

oeway commented Feb 6, 2024

Wasn't the consensus to switch to bioimageio.yaml??

No, if I remember correctly the concensus was to not touch it, see the last item in the meeting minutes here: bioimage-io/bioimage.io#28 (comment)

@FynnBe
Copy link
Member

FynnBe commented Feb 6, 2024

ah, thanks, sorry for the confusion!

@oeway
Copy link
Contributor

oeway commented Aug 28, 2024

@FynnBe
@mese79 mentioned:

Uploader expects a rdf.yaml file to be present in the model zip package, but the spec export functionality puts the model specs bioimageio.yaml file.

I thought you already changed back to rdf.yaml, could you confirm?

@mese79
Copy link
Contributor

mese79 commented Aug 28, 2024

Anyway, I've made a PR:
#93

@FynnBe
Copy link
Member

FynnBe commented Aug 28, 2024

I thought you already changed back to rdf.yaml, could you confirm?

I thought I had, but in fact there is still a preference of bioimageio.yaml over rdf.yaml I suppose...
Made a PR to fix it in the next spec release: bioimage-io/spec-bioimage-io#626

@FynnBe
Copy link
Member

FynnBe commented Aug 28, 2024

ah, I remember: I did change how the collection handles it, so that on bioimage.io it's all rdf.yaml...
I suppose the PR would still be good to avoid confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants