Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure continuous recording #69

Open
Remi-Gau opened this issue Apr 12, 2024 · 6 comments
Open

ensure continuous recording #69

Remi-Gau opened this issue Apr 12, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@Remi-Gau
Copy link
Contributor

ensures that the file generated have continuous recording

@julia-pfarr
Copy link
Member

What does that mean exactly? I'm sorry, I've always had troubles understanding this. Does that have to do with the timestamps? The samples do have continuous recording (=_recording-_physio.tsv.gz file). The events (=_recording-_physioevents.tsv.gz) does not. So for the events we would have to add extra "empty" rows that the timestamp is continous?

Is that what you mean? (asking because I'm currently working on the code for the _physioevents.tsv.gz file)

@Remi-Gau
Copy link
Contributor Author

Yes the idea would be to pad physio.tsv.gz with rows of n/a for missing time stamps.

@julia-pfarr
Copy link
Member

Ok, yes, I discussed this in our last meeting with Oscar and Martin. So the data (=physio.tsv.gz) should have continuous recording and I still need to modify the edf2bids code that it checks for continuity and if not fill with n/a rows. The events file however (=physioevents.tsv.gz) should not be continuous.

@julia-pfarr julia-pfarr added the enhancement New feature or request label Jul 1, 2024
@julia-pfarr
Copy link
Member

todo:
add function to check the samples for continuous recordings; if False fill missing rows with continuous timestamps and nans for coordinates/pupil

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Oct 3, 2024

OK I need to make sure that we have a test that actually make sure we throw a warning or an error if the output file does not have a continuous timestamp

@julia-pfarr
Copy link
Member

But I thought we want to take care of it?

Yes the idea would be to pad physio.tsv.gz with rows of n/a for missing time stamps.

This and the last discussions in the meetings sounded to me as if we check during the conversion process if timestamps are continuous and if not we modify the tsv by adding the rows, no? We can still throw a warning letting the user know that we modified their file in this manner but an error would mean we leave it to the user to take care of it themselves and run our converter again afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants