Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eyetracking setup 'geometry' #103

Open
julia-pfarr opened this issue Oct 2, 2024 · 1 comment · May be fixed by #112
Open

Eyetracking setup 'geometry' #103

julia-pfarr opened this issue Oct 2, 2024 · 1 comment · May be fixed by #112
Assignees

Comments

@julia-pfarr
Copy link
Member

bids-standard/bids-specification#1128 (review)

Watch discussion and change code if accepted

@julia-pfarr julia-pfarr self-assigned this Oct 2, 2024
@julia-pfarr julia-pfarr moved this to Todo in eye2bids Oct 2, 2024
@julia-pfarr
Copy link
Member Author

https://github.com/bids-standard/bids-specification/pull/1128/files/26c463ae613556368763590a2d8b9e81120bc0f9

"EyetrackingGeometry" : {
"EyeToCameraX": 0.05,
"EyeToCameraY": 0.30,
"EyeToCameraZ": 0.40,
"EyeToScreenTopLeftX": 0.15,
"EyeToScreenTopLeftY": 0.1,
"EyeToScreenTopLeftZ": 0.50
}

Oscars suggestion:
{
"EyeToCameraXYZ": [0.05, 0.30, 0.40],
"EyeToScreenTopLeftXYZ": [0.15, 0.1, 0.5],
}

julia-pfarr added a commit that referenced this issue Nov 19, 2024
- change name to "eyelink_metadata.yml" so that it has a unique name for 1. ezBIDS to look for in a folder and 2. for EyeLink because other eyetrackers will have other missing metadata and need their own file for the manual metadata
- change tests to look for new filename
- include commit 6e787b6 of metadata schema from bids specification
@julia-pfarr julia-pfarr linked a pull request Nov 19, 2024 that will close this issue
@julia-pfarr julia-pfarr moved this from Todo to In Progress in eye2bids Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant