Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dot character in service names #20

Open
santo-codes opened this issue Mar 15, 2022 · 1 comment · May be fixed by #21
Open

Allow dot character in service names #20

santo-codes opened this issue Mar 15, 2022 · 1 comment · May be fixed by #21

Comments

@santo-codes
Copy link

santo-codes commented Mar 15, 2022

Is your feature request related to a problem? Please describe.
Currently queries of the form <name>.service.<domain> are supported. <name> values cannot have the dot character. Services in our project tend to have the dot character. Can it be supported please?

Describe the solution you'd like
Solution is simple. SERVICE_NAME_REGEX in DnsQueryHandler needs minor change. Add \\. in the first capturing group. I.e.

private static final String SERVICE_NAME_REGEX = "^_?([\\w\\-\\.]+)\\.(?:_\\w+\\.)?(?:service|connect)\\.";

Describe alternatives you've considered
None.

Additional context
None.

@santo-codes
Copy link
Author

I can raise a PR if this feature request looks ok.

@santo-codes santo-codes linked a pull request Mar 16, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant