Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation dependencies? #10

Open
pierrepo opened this issue Jun 29, 2020 · 2 comments
Open

Installation dependencies? #10

pierrepo opened this issue Jun 29, 2020 · 2 comments

Comments

@pierrepo
Copy link

This is more a question than an issue on itself 😄

The installation procedure for notebook-as-pdf is quite straightforward:

python -m pip install notebook-as-pdf
pyppeteer-install

I had a quick look at the files inside the binder repo that are used to build the demo with mybinder:

  • notebook-as-pdf is installed through requirements.txt
  • and the postBuild script runs pyppeteer-install

However, the apt.txt file contains a list of Ubuntu/Debian libraries. Are they related to the installation of notebook-as-pdf on itself?

@betatim
Copy link
Owner

betatim commented Jun 29, 2020

Yes, I needed to install the extra packages on the Ubuntu base image that is used by repo2docker. However I haven't spent much time check if this is really the minimal set of extra packages to install or not. If you find something that isn't strictly necessary it would be nice to know/remove it.

https://github.com/pyppeteer/pyppeteer doesn't list any extra dependencies so maybe all of apt.txt can go?

@pierrepo
Copy link
Author

A quick test told me apt.txt is required, at least some of its content.

@betatim betatim mentioned this issue Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants