Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Map view search controls #168

Merged
merged 15 commits into from
Jul 15, 2024
Merged

feat: Map view search controls #168

merged 15 commits into from
Jul 15, 2024

Conversation

ccallendar
Copy link
Contributor

@ccallendar ccallendar commented Jul 10, 2024

Description

Made the following changes:

  • Added search input (large screen) and button (small screens) - working but no dropdown yet
  • Added Find Me button (large screen) and control (small screens)
  • Added Polygon and Point Search buttons (disabled for now)
  • Added Search By button (working)
  • Added Filter By button (working)
  • Added Zoom In/Out controls

Fixes #161

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit tests
  • End to end tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Also updated some package versions.


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@mishraomp
Copy link
Contributor

@ccallendar Chris , can we make this draft and move it review later when you are done

@ccallendar ccallendar marked this pull request as draft July 11, 2024 00:25
@ccallendar ccallendar changed the title feat: WIP Map view search controls feat: Map view search controls Jul 11, 2024
@ccallendar ccallendar marked this pull request as ready for review July 11, 2024 17:34
@mishraomp
Copy link
Contributor

@ccallendar , could you please look at the sonar security warning

@dawnbcgov dawnbcgov requested a review from kdbelair July 11, 2024 22:39
Copy link

sonarcloud bot commented Jul 15, 2024

Quality Gate Passed Quality Gate passed for 'nr-omrr-transparency-frontend'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
92.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work :)

@ccallendar ccallendar merged commit 91ac519 into main Jul 15, 2024
18 checks passed
@ccallendar ccallendar deleted the feat/map-search-components branch July 15, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add map search buttons
2 participants