Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dashboard text and style changes #167

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Conversation

ccallendar
Copy link
Contributor

@ccallendar ccallendar commented Jul 9, 2024

Description

Updated the Dashboard page in the following way:

  • Moved to new pages folder
  • Separated into 3 sections (top, info, learn more)
  • Added new "Search on a map" button in top section
  • Removed yellow background in info section replaced the image
  • Small text changes through out

Fixes #164

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit tests (added new)
  • End to end tests (updated existing)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link

sonarcloud bot commented Jul 9, 2024

Quality Gate Passed Quality Gate passed for 'nr-omrr-transparency-backend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jul 9, 2024

Quality Gate Failed Quality Gate failed for 'nr-omrr-transparency-frontend'

Failed conditions
4.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ccallendar ccallendar merged commit 1687756 into main Jul 10, 2024
18 of 19 checks passed
@ccallendar ccallendar deleted the feat/dashboard-text-changes branch July 10, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard text and style changes
2 participants