Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCMOHAD-24687 & BCMOHAD-24689 #1378

Merged
merged 10 commits into from
Nov 8, 2024
Merged

BCMOHAD-24687 & BCMOHAD-24689 #1378

merged 10 commits into from
Nov 8, 2024

Conversation

mhussaincgi
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

List high-level changes as bullet items

Below are some examples

  • Changed field permissions
  • changed field data-type

Deployment Tracker

List all the metadata that is pushed in this commit/PR. Full URL should be fine.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@RanadheerRG RanadheerRG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link

sonarcloud bot commented Nov 8, 2024

@cgijeffolsen cgijeffolsen self-requested a review November 8, 2024 16:40
Copy link
Collaborator

@cgijeffolsen cgijeffolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RanadheerRG RanadheerRG merged commit 452131b into main Nov 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants