Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make division counting consistent between implementations #55

Open
jessicasyu opened this issue Oct 11, 2024 · 0 comments
Open

Make division counting consistent between implementations #55

jessicasyu opened this issue Oct 11, 2024 · 0 comments
Labels
category: agent Related to the agent subpackages package: patch Related to the patch implementation package: potts Related to the potts implementation type: feature Improvement or additions to the code base

Comments

@jessicasyu
Copy link
Member

Currently, when the make method for creating a new cell is called:

  • the potts implementation increases the number of divisions (divisions++)
  • the patch implementation decreases the number of divisions (divisions--)

We should either (1) change patch to also increase the number of divisions (and handle the DIVISION_POTENTIAL parameter appropriately for senescence) or (2) switch potts to decrease.

I think (2) is easier to implement, but (1) makes more intuitive sense.
@jessicasyu jessicasyu added category: agent Related to the agent subpackages package: patch Related to the patch implementation package: potts Related to the potts implementation type: feature Improvement or additions to the code base labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: agent Related to the agent subpackages package: patch Related to the patch implementation package: potts Related to the potts implementation type: feature Improvement or additions to the code base
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jessicasyu