Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar always 100% #229

Open
georgepapas123 opened this issue Oct 22, 2024 · 8 comments
Open

Progress bar always 100% #229

georgepapas123 opened this issue Oct 22, 2024 · 8 comments
Labels

Comments

@georgepapas123
Copy link

Progress bar jumps immediately to 100% and stays there until finished.
onOTAProgress() works properly showing steady increments until complete.
Why can't progress bar be updated in onOTAProgress() also?
Using Windows 10 22H2, Arduino IDE 2.3.3, ESP8266, EspAsyncWebServer 3.3.17, ElegantOTA 3.1.6 async mode

@ayushsharma82
Copy link
Owner

ayushsharma82 commented Oct 22, 2024

@georgepapas123 It's an issue with apple devices (specifically how Safari caches requests) and there is no work around for it. You can try the same on any other browser and it will work fine.

@ayushsharma82
Copy link
Owner

Just noticed you wrote "Windows". Are you trying to upload the bin file through windows itself or from any apple device?

@georgepapas123
Copy link
Author

The upload is done on Windows using Firefox 131.0.3 (64-bit).
You got me thinking and I tried Opera and it works so I guess chrome based browsers work.
It seems it's something in Firefox, but since a lot of people use Firefox if it's something simple it would be great to be fixed.

@ayushsharma82
Copy link
Owner

Thanks for the insight. I'll give it a look soon if that can be fixed.

Usually the progress bar breaks because the browser is doing some sort of caching due to security concerns over HTTP protocol and it doesn't report back exact amount of bytes sent to server. There is no getting around it for the time being if this is the case (like Safari browser) because it's a browser level restriction.

@georgepapas123
Copy link
Author

For "problematic" browsers like Firefox, Safari etc. may I suggest a palindromic progress bar, going back and forth until completion, then you would just hide it and show the success (or failure) message.
This will be incredibly useful in systems where people now see a frozen progress bar and think OTA failed because they may not wait for about a minute or so to see the process complete.

@ayushsharma82
Copy link
Owner

@georgepapas123 Good idea. I'll implement that.

@georgepapas123
Copy link
Author

Great! Thanks!

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants