Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StackOverflowError occurs when computing Simplify(Sin(Pi*Cosh(45522*Csc(17/36*Pi)))) #930

Open
tranleduy2000 opened this issue Mar 10, 2024 · 2 comments
Open

StackOverflowError occurs when computing Simplify(Sin(Pi*Cosh(45522*Csc(17/36*Pi)))) #930

tranleduy2000 opened this issue Mar 10, 2024 · 2 comments
Assignees
@axkr
Labels
bug

Comments

@tranleduy2000
Copy link
Collaborator

There is the input

Simplify(Sin(Pi*Cosh(45522*Csc(17/36*Pi))))
image 
java.lang.StackOverflowError
	at org.matheclipse.core.expression.F.ast(F.java:8625)
	at org.matheclipse.core.expression.F.PlusAlloc(F.java:14349)
	at org.matheclipse.core.reflection.system.TrigExpand$TrigExpandFunction.expandCoshPlus(TrigExpand.java:284)
	at org.matheclipse.core.reflection.system.TrigExpand$TrigExpandFunction.expandCoshPlus(TrigExpand.java:292)
	at org.matheclipse.core.reflection.system.TrigExpand$TrigExpandFunction.expandCoshPlus(TrigExpand.java:292)
	at org.matheclipse.core.reflection.system.TrigExpand$TrigExpandFunction.expandCoshPlus(TrigExpand.java:292)
	at org.matheclipse.core.reflection.system.TrigExpand$TrigExpandFunction.expandCoshPlus(TrigExpand.java:292)
	at org.matheclipse.core.reflection.system.TrigExpand$TrigExpandFunction.expandCoshPlus(TrigExpand.java:292)
	at org.matheclipse.core.reflection.system.TrigExpand$TrigExpandFunction.expandCoshPlus(TrigExpand.java:292)
	at org.matheclipse.core.reflection.system.TrigExpand$TrigExpandFunction.expandCoshPlus(TrigExpand.java:292)
	at org.matheclipse.core.reflection.system.TrigExpand$TrigExpandFunction.expandCoshPlus(TrigExpand.java:292)
@axkr
Copy link
Owner

axkr commented Mar 10, 2024 •
edited
Loading

Best solution would be to transform these recursions in TrigExpand into an iterative loop.

"Work around" can be to set: Config.MAX_AST_SIZE = 20000 to avoid to big expressions.

@axkr axkr self-assigned this Mar 10, 2024
@axkr axkr added the bug label Mar 10, 2024
axkr added a commit that referenced this issue Mar 10, 2024
@axkr
WIP #930 iterative function for TrigExpand of Cosh / Sinh(a+b+c)
7de2624
@axkr
Copy link
Owner

axkr commented Mar 10, 2024 •
edited
Loading

TODO replace other recursive versions in TrigExpand#expandPlus() with iterative versions

axkr added a commit that referenced this issue Mar 10, 2024
@axkr
WIP #930 iterative function for TrigExpand of Cosh / Sinh(a+b+c)
e9188ef
axkr added a commit that referenced this issue Mar 10, 2024
@axkr
WIP #930 iterative functions for TrigExpand
286f66d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@axkr axkr

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@axkr @tranleduy2000