This repository has been archived by the owner on Oct 4, 2022. It is now read-only.
V1.27.0 emotionfx memory fixes #535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this is great! I'll work on getting these optimizations into LY Vanilla! |
AMZN-Gene
reviewed
Apr 21, 2021
| @@ -634,6 +634,7 @@ namespace EMotionFX | |||
| // get rid of shared data | |||
| ResetSharedData(sharedData); | |||
| sharedData.Clear(); | |||
| sharedData.Shrink(); | |||
There was a problem hiding this comment.
Is the clear/shrink needed since sharedData is going out of scope and will be destroyed?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are set of memory improvements, as discussed on the private forum, LY-23014
See discussion topic for more info and results.
Next changes were made:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.