fix: close AWS config #8134
fix: close AWS config #8134
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @testwill. Thanks for your PR. I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
eks-distro-bot
added
the
size/XS
|
Can you update the description section of this PR? the testing part as well |
| @@ -134,6 +134,7 @@ func ParseAWSConfig(ctx context.Context, awsConfig string) (*aws.Config, error) | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| defer file.Close() | |||
There was a problem hiding this comment.
Can you provide more context in the PR description on why this is needed?
Issue #, if available:
Description of changes:
close AWS config
Testing (if applicable):
test success
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.