Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamodb: read_items support for ScanIndexForward #3017

Open
mccauleyp opened this issue Nov 12, 2024 · 1 comment
Open

dynamodb: read_items support for ScanIndexForward #3017

mccauleyp opened this issue Nov 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@mccauleyp
Copy link

mccauleyp commented Nov 12, 2024

Is your idea related to a problem? Please describe.
Thanks for the great resource! It'd be great if the dynamodb.read_items method could be enhanced slightly to support changing the ScanIndexForward option on the DynamoDB query call.

https://aws-sdk-pandas.readthedocs.io/en/3.7.2/stubs/awswrangler.dynamodb.read_items.html
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/dynamodb/client/query.html

Describe the solution you'd like
I'd suggest exposing a scan_index_forward boolean kwarg on the method and explicitly propagating that down into the boto3 call, but potentially you could expose boto3_additional_kwargs similar to the existing pyarrow_additional_kwargs to allow for arbitrary additional kwargs.

@mccauleyp mccauleyp added the enhancement New feature or request label Nov 12, 2024
@mccauleyp mccauleyp changed the title dynamodb: read_items method supports ScanIndexForward dynamodb: read_items support for ScanIndexForward Nov 12, 2024
@jaidisido
Copy link
Contributor

jaidisido commented Nov 15, 2024

Adding ScanIndexForward as an argument would be relatively simple. My concern here is that the dynamodb.read_items API is not specific to Query. It abstracts all of GetItem, Query and Scan operations. If we are to support every individual arguments, the API would quickly become overloaded. A dynamodb_kwargs argument would help but then it would require a complex logic to filter the right arguments for each underlying operation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants