-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decrease compile time. #26
Comments
Have made |
we can remove https://github.com/avhz/RustQuant/blob/634735dd5d860af26f5e31091aca44ee69ea2430/Cargo.toml#L45C16-L45C16 and edit data = ["dep:polars/default"] Line 56 in 634735d
|
The way I have it currently reduces the number of dependencies compiled from 400+ to around 270-280. Are you saying we should remove |
Ohh My bad we can keep it as true and data = [] ( empty) , the data feature is disabled by default, meaning Polars will not be included in the compilation process unless explicitly enabled using the --features data flag or specifying features = ["data"] in the Cargo.toml file. |
But Why do you want to have |
Hello! Came here by the first good issue tag. Is this still a problem? Maybe separate the project into smaller crates could improve the compile time |
@kelvincesar thanks for the comment :) I have considered doing this but am worried about running into issues with the orphan rules. |
@avhz you're right, that can be a problem. In this case we would have to create new types around the existing ones plus replicate their methods (https://doc.rust-lang.org/book/ch19-03-advanced-traits.html#using-the-newtype-pattern-to-implement-external-traits-on-external-types). I don't know if this make sense |
Compile time increased quite substantially after adding Polars as a dependency.
Should look into reducing the compile time a bit if possible.
The text was updated successfully, but these errors were encountered: