Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove matplotlib dependency #159

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Remove matplotlib dependency #159

merged 1 commit into from
Nov 19, 2024

Conversation

AnirudhDagar
Copy link
Collaborator

Description

I believe matplotlib can be safely removed since it is not an AGA dependency. I also made some minor updates to readme.

How Has This Been Tested?

  • Unit tests (pytest tests/)
  • Integration tests (if applicable)
  • Checked locally that we don't use/import matplotlib anywhere. It was probably there since Garrett had it for generating the benchmark plots earlier, and we never cleaned it up after the initial refactor dividing the autogluon-assistant and autogluon-assistant-tools repo.

Configuration Changes

  • No config changes
  • Config changes (please describe):

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Performance improvement
  • Code cleanup/refactor

@boranhan boranhan merged commit 6e6eafa into main Nov 19, 2024
5 checks passed
@boranhan boranhan deleted the matplotlib_dep branch November 19, 2024 15:35
@AnirudhDagar AnirudhDagar mentioned this pull request Nov 19, 2024
Merged
@tonyhoo
Copy link
Contributor

tonyhoo commented Nov 19, 2024 •
edited
Loading

/platform_tests
Platform Tests Output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boranhan boranhan boranhan approved these changes

@tonyhoo tonyhoo Awaiting requested review from tonyhoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnirudhDagar @tonyhoo @boranhan