Adding client credentials support #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evansims
previously requested changes
Oct 24, 2024
kishore7snehil
force-pushed
the
feature/adding_client_credentials
branch
from
af015cf
to
912806d
Compare
duedares-rvj
approved these changes
Nov 5, 2024
kishore7snehil
dismissed
evansims’s stale review
The suggested changes are incorporated.
Merged
kishore7snehil
added a commit
that referenced
this pull request
Nov 7, 2024
### Added - Adding client credentials support [\#775](#775) ([kishore7snehil](https://github.com/kishore7snehil)) - Adding Support For CYOK [\#779](#779) ([kishore7snehil](https://github.com/kishore7snehil)) ### Fixed - fix jobs test fail [\#773](#773) ([yasuaki640](https://github.com/ramonschriks))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Support for Default Organisation in clients
a. Added new field default_organization to GET/PATCH endpoints /api/v2/clients/{id}
b. Added new field default_organization to POST endpoints /api/v2/clients/
Support query param q for GET /api/v2/clients
a. q=client_grant.organization_id:org_<uniq_id>
b. q=client_grant.allow_any_organization:true
Support query param grant_ids for GET /api/v2/organizations/{org_id}/client-grants
Support query param identifiers for GET /api/v2/resource-servers
References
Management API Documentation
Internal Reference
Testing
Added test cases for testing above end-points.
Tested the implementation manually according to this internal document
This change adds unit test coverage
[] This change adds integration test coverage
This change has been tested on the latest version of the platform/language or why not
Contributor Checklist