Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple disabling SSL v3.0... do we need to make changes to Net::APNS::Persistent? #2

Open
janngobble opened this issue Oct 23, 2014 · 4 comments

Comments

@janngobble
Copy link

As of Oct 29th Apple is killing support for SSLv3 in the APNS system.

https://developer.apple.com/news/?id=10222014a

Do we need to change the way we use Net::APNS::Persistent and/or update the module?

PS: We should also update max_payload_size to be 2048 as of iOS8...

@fifanrg
Copy link

fifanrg commented Nov 5, 2014

Hi does any know how to resolve this? I am having the same problem, it does not seem to be working now....

@aufflick
Copy link
Owner

aufflick commented Nov 6, 2014

The SSL support for Net::APNS::Persistent is provided by Net::SSLeay. The latest Net::SSLeay seems to support up to TLS v1.2, presumably depending on the version of openssl it's linked against also.

It looks like all that needs to happen is to replace the call to Net::SSLeay::CTX_new() in Base.pm with Net::SSLeay::CTX_tlsv1_new() or CTX_tlsv1_1_new() or CTX_tlsv1_2_new(). That does somewhat change the exact features available, but we're using very few features so I wouldn't be surprised if just dropping in that change fixes it.

Having said that I don't have any services using this any more so I'm not really able to test. If either of you can try making that change and making a pull request if it works I'm more than happy to release a new CPAN version based on that.

@aufflick
Copy link
Owner

aufflick commented Nov 6, 2014

FYI The code currently includes this:

$Net::SSLeay::ssl_version = 10; # Insist on TLSv1

But I guess that doesn't actually have effect when we're using CTX_new() directly.

@danjger
Copy link
Contributor

danjger commented Aug 20, 2015

I ran into this issue and replacing CTX_new with CTX_tlsv1_2_new did the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants