Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astropy v7.0: some removed functionality is used in tests #3131

Open
pllim opened this issue Nov 11, 2024 · 1 comment
Open

astropy v7.0: some removed functionality is used in tests #3131

pllim opened this issue Nov 11, 2024 · 1 comment
Labels

Comments

@pllim
Copy link
Member

pllim commented Nov 11, 2024

According to astropy-integration-testing run, there is failure with stable version but not dev, so this package needs a new release to be compatible with astropy v7.0.0 (but only if you want the affected test to pass, not change to package functionality). FYI.

@bsipocz
Copy link
Member

bsipocz commented Nov 11, 2024

The failures are in the tests/testing imports, and none of the actual astroquery functionalities are affected.

And I really do not appreciate that such an out of deprecation cycle API change would force us to release here; especially to make it happen urgently, so would rather just pass the ball back and would like to ask the revert of this PR from the 7.0 release in favour of doing it properly, with a deprecation at first, after all these functions were explicitly part of the API and were listed in __all__, too.

@bsipocz bsipocz changed the title astropy v7.0: This package needs a new release astropy v7.0: some removed functionality is used in tests Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants