Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return integer instead of string for the CDS xmatch #52

Open
JulienPeloton opened this issue Jun 23, 2020 · 0 comments
Open

Return integer instead of string for the CDS xmatch #52

JulienPeloton opened this issue Jun 23, 2020 · 0 comments
Assignees
Labels

Comments

@JulienPeloton
Copy link
Member

The crossmatch module returns the type of object as a string, based on the classification at http://simbad.u-strasbg.fr/simbad/sim-display?data=otypes. But then, we use this classification to link alerts of the same kind (in grafink for example), which can be slow. Comparing integers would be faster than strings.

Action item: return the integer type instead of the string one, and build a mapping to perform the conversion if necessary. The mapping can be accessed at http://simbad.u-strasbg.fr/simbad/sim-tap (with SELECT * FROM otypedef).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Feature
Development

No branches or pull requests

1 participant