Add dummy middleware that removes ESI tags from the DOM #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comments and all
just appended the import to reduce LOC changed.
|
bump. issue #14 is driving me crazy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14
Functionality is complete, but missing changes to support.
If
'armstrong.esi.middleware.DummyEsiMiddleware'is in yourMIDDLEWARE_CLASSES, esis will be rendered as comments instead of esi tags:instead of the rendered esi or the original esi tag:
RFC
The thought presently occurs that perhaps this should be NullEsiMiddleware instead of DummyEsiMiddleware.
TODO