Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raw esi tag creates broken html #14

Open
crccheck opened this issue Feb 15, 2013 · 0 comments
Open

raw esi tag creates broken html #14

crccheck opened this issue Feb 15, 2013 · 0 comments

Comments

@crccheck
Copy link
Member

I like to turn ESI off in development because of reasons. But today, I discovered that it's causing my HTML to break. The issue I'm having is that with the html5 doctype, the rendering engines are not auto-closing the esi tag. So

<esi:include src="/teh/poniez.html" />
<p>This tag should be a sibling to ESI</p>

Turns into

<esi:include src="/teh/poniez.html">
    <p>This tag should be a sibling to ESI</p>
</esi>

Which significantly changes the structure. We can't change the tag, because Vanish (and presumably Akamai, et al.) expect it to be self-closing, but we could have a dummy middleware that replaced it with an html comment (e.g. <!--esi:include src="/teh/poniez.html" /-->).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant