Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propogate exceptions to caller #6

Open
d79ima opened this issue Jan 10, 2020 · 1 comment
Open

propogate exceptions to caller #6

d79ima opened this issue Jan 10, 2020 · 1 comment

Comments

@d79ima
Copy link

d79ima commented Jan 10, 2020

I noticed occasionally call to ServiceBrowser.Browse would result in exception being silently thrown, which i only noticed on the debugger in Visual Studio:
Exception thrown: 'ArkaneSystems.Arkane.Zeroconf.Providers.Bonjour.ServiceErrorException' in Arkane.Zeroconf.dll

Exception is being silently dropped in Providers/Bonjour/ServiceBrowser.cs Start(async = true) method.
Because of this.task = Task.Run (() => this.ProcessStart ()).ContinueWith (_ => this.task = null) ;
Task.Run just drops any exceptions thrown by ProcessStart().

Could you please provide a public API that is friendly with async/await that exposes Task as a return value so caller can decide how best to handle exceptions on async calls.
Or at a minimum provide an option to use Synchronous Browse and let caller handle async routing on their own

@cerebrate
Copy link
Member

Exception is now propagated upwards, per first version of this issue. Considering further updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants