Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrecursorAction with continuous variables #147

Open
smpark7 opened this issue Jan 19, 2021 · 3 comments
Open

PrecursorAction with continuous variables #147

smpark7 opened this issue Jan 19, 2021 · 3 comments

Comments

@smpark7
Copy link
Collaborator

smpark7 commented Jan 19, 2021

This issue can be closed when PrecursorAction supports continuous precursor concentration variables and generates accurate precursor distributions with it.

Background

Solving for the precursor concentration with the discontinuous Galerkin method is good for many problems because it is stable and fairly accurate under high Schmidt number (convection-dominated). However, it has some disadvantages:

  • Limited fidelity with CONSTANT MONOMIAL shape functions (particularly in regions with large gradients)
  • Number of DOFs increases significantly (x4) when used with first-order L2-Lagrange shape functions

Results so far

Preliminary work here showed that continuous Galerkin stabilized with isotropic artificial diffusion (ScalarAdvectionArtDiff) gave worse results because isotropic artificial diffusion is overly diffusive. We can expect better performance when we implement a more advanced stabilization techniques such as SUPG or FIC. Refer to the README for more information on how to generate the results and further discussion.

@katyhuff
Copy link
Member

@smpark7 -- Where are we on this. Is it still needed?

@smpark7
Copy link
Collaborator Author

smpark7 commented May 22, 2024

  • Limited fidelity with CONSTANT MONOMIAL shape functions (particularly in regions with large gradients)

With #266, PrecursorAction will natively support higher order MONOMIAL or L2_LAGRANGE discontinuous shape functions for precursor variables.

  • Number of DOFs increases significantly (x4) when used with first-order L2-Lagrange shape functions

This may not be an issue because MONOMIAL shape functions have fewer DOFs for the same mesh resolution.

Where are we on this. Is it still needed?

Maybe. We will find out how well the current system works when I try coupling precursor drift with turbulent flow in the MSRE and MCRE (in the next two months). It's possible we may want both continuous and discontinuous systems available if they have complementary strengths.

@katyhuff
Copy link
Member

Thanks. I'm going to unassign myself.

@katyhuff katyhuff removed their assignment May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants