New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4 4's and a 5 are incorrectly scored as a farkle #1

Open

arbrown opened this issue Jun 10, 2013 · 1 comment

Assignees

Owner

arbrown commented Jun 10, 2013

I noticed this incorrect debug output when testing the Human input mode...

 Starting turn #19
 Human starting turn
  Rolled: [4 4 6 5 4 4]
          [0 1 2 3 4 5]
Which dice to keep? 01453
Continue rolling? n
  Keeping 4, 4, 5, 4, 4
Kept Dice Count: 5
[0 0 0 4 1 0]
Human farkle count: 1
Adding 0 to current run score of 0
 Human scored 0

I don't know whether the 4's matter or if it's any 4 of a kind with something extra (1 or 5) but something is fishy here.

The text was updated successfully, but these errors were encountered:

Owner Author

arbrown commented Jun 12, 2013

I think this is fixed in 60f00fc. But I need to write some unit tests to be sure.

ghost assigned arbrown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment