Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the branch ref to default to github.ref #15425

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

areshand
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@areshand areshand requested a review from a team as a code owner November 28, 2024 04:13
Copy link

trunk-io bot commented Nov 28, 2024

⏱️ 1h 10m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-tests 13m 🟩
rust-move-tests 12m 🟩
replay-mainnet / run-replay-verify 7m 🟥🟥🟥🟥
rust-move-tests 7m
rust-cargo-deny 7m 🟩🟩🟩🟩 (+1 more)
test-target-determinator 6m 🟩
check-dynamic-deps 6m 🟩🟩🟩🟩🟩 (+2 more)
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+2 more)
general-lints 2m 🟩🟩🟩🟩 (+1 more)
rust-move-tests 2m
file_change_determinator 1m 🟩🟩🟩🟩 (+2 more)
determine-test-metadata 50s 🟩🟩🟩🟩🟩 (+1 more)
determine-test-metadata 40s 🟩🟩🟩🟩
file_change_determinator 22s 🟩🟩
permission-check 22s 🟩🟩🟩🟩🟩 (+2 more)

settingsfeedbackdocs ⋅ learn more about trunk.io

@areshand areshand force-pushed the fix_branch branch 2 times, most recently from 04e42b8 to 06fe79a Compare November 28, 2024 04:57
@areshand areshand added the CICD:build-images when this label is present github actions will start build+push rust images from the PR. label Nov 28, 2024
@areshand areshand changed the title remove the branch ref to default to main remove the branch ref to default to github.ref Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:build-images when this label is present github actions will start build+push rust images from the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant