Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky test #15407

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix flaky test #15407

wants to merge 1 commit into from

Conversation

areshand
Copy link
Contributor

Description

error is Uniform::new called with low >= high

ensure high is always greater than low now

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 26, 2024

⏱️ 21m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 12m 🟩
check-dynamic-deps 4m 🟩🟩
rust-cargo-deny 2m 🟩
semgrep/ci 53s 🟩🟩
general-lints 45s 🟩
file_change_determinator 23s 🟩🟩
permission-check 11s 🟩🟩
rust-move-tests 11s
permission-check 11s 🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 3m 1m +104%

settingsfeedbackdocs ⋅ learn more about trunk.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant