Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registry tool: ensure yaml archive storage works across all tests #1203

Open
theganyo opened this issue Jun 20, 2023 · 2 comments · May be fixed by #1206
Open

Registry tool: ensure yaml archive storage works across all tests #1203

theganyo opened this issue Jun 20, 2023 · 2 comments · May be fixed by #1206
Labels
enhancement New feature or request

Comments

@theganyo
Copy link
Member

Follow-up from an earlier YAML storage PR:

--- FAIL: TestConformance (0.19s)
    --- FAIL: TestConformance/normal_case (0.05s)
        conformance_test.go:465: Failed getting artifact contents projects/conformance-test/locations/global/apis/petstore/versions/1.0.0/specs/openapi/artifacts/conformance-openapitest: rpc error: code = NotFound desc = "projects/conformance-test/locations/global/apis/petstore/versions/1.0.0/specs/openapi/artifacts/conformance-openapitest" not found in database
    --- FAIL: TestConformance/default_case (0.04s)
        conformance_test.go:465: Failed getting artifact contents projects/conformance-test/locations/global/apis/petstore/versions/1.0.0/specs/openapi/artifacts/conformance-openapitest-default: rpc error: code = NotFound desc = "projects/conformance-test/locations/global/apis/petstore/versions/1.0.0/specs/openapi/artifacts/conformance-openapitest-default" not found in database
    --- FAIL: TestConformance/multiple_severity (0.03s)
        conformance_test.go:465: Failed getting artifact contents projects/conformance-test/locations/global/apis/petstore/versions/1.0.0/specs/openapi/artifacts/conformance-openapitest-multiple-severity: rpc error: code = NotFound desc = "projects/conformance-test/locations/global/apis/petstore/versions/1.0.0/specs/openapi/artifacts/conformance-openapitest-multiple-severity" not found in database
    --- FAIL: TestConformance/multiple_state (0.04s)
        conformance_test.go:465: Failed getting artifact contents projects/conformance-test/locations/global/apis/petstore/versions/1.0.0/specs/openapi/artifacts/conformance-openapitest-multiple-state: rpc error: code = NotFound desc = "projects/conformance-test/locations/global/apis/petstore/versions/1.0.0/specs/openapi/artifacts/conformance-openapitest-multiple-state" not found in database
    --- FAIL: TestConformance/multiple_linter (0.04s)
        conformance_test.go:465: Failed getting artifact contents projects/conformance-test/locations/global/apis/petstore/versions/1.0.0/specs/openapi/artifacts/conformance-openapitest-multiple-linter: rpc error: code = NotFound desc = "projects/conformance-test/locations/global/apis/petstore/versions/1.0.0/specs/openapi/artifacts/conformance-openapitest-multiple-linter" not found in database

I couldn't identify why these were failing as the conformance tests aren't really unit tests - they start processes and move data around in ways that are hidden from the test suite. In addition, nothing was logged that indicated what the root cause might be.
@theganyo theganyo self-assigned this Jun 20, 2023
@theganyo theganyo moved this from Inbox to Pressing in Apigee API Registry Jun 20, 2023
@theganyo theganyo added the enhancement New feature or request label Jun 20, 2023
@theganyo
Copy link
Member Author

Original issue: #946

@theganyo theganyo moved this from Pressing to In Progress in Apigee API Registry Jun 21, 2023
@theganyo theganyo changed the title ensure archive storage works across all tests ensure yaml archive storage works across all tests Jun 21, 2023
@theganyo
Copy link
Member Author

Investigation reveals that at least part of the issue appears to be that the conformance relies on Id, but Id and Kind are not being stored in the YAML.

@theganyo theganyo linked a pull request Jun 26, 2023 that will close this issue
Open
@timburks timburks changed the title ensure yaml archive storage works across all tests Registry tool: ensure yaml archive storage works across all tests Jul 13, 2023
@theganyo theganyo removed their assignment Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Apigee API Registry
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix yaml archives for conformance theganyo/registry
1 participant
@theganyo