Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi table joins error and add more integration tests #14188

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Beyyes
Copy link
Member

@Beyyes Beyyes commented Nov 23, 2024

Description

In current version, cross join is not supported.

Sql like below is actual cross join because EquiJoinClauses num is only two.

select *
from students s, teachers t, courses c, grades g
where s.time=c.time and c.time=g.time

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Copy link

sonarcloud bot commented Nov 23, 2024

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.65%. Comparing base (24a0090) to head (300c514).

Files with missing lines Patch % Lines
...nner/optimizations/PushPredicateIntoTableScan.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #14188   +/-   ##
=========================================
  Coverage     39.64%   39.65%           
  Complexity       71       71           
=========================================
  Files          4232     4232           
  Lines        269637   269640    +3     
  Branches      32688    32689    +1     
=========================================
+ Hits         106897   106923   +26     
+ Misses       162740   162717   -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Beyyes Beyyes changed the title Fix cross join error and add it Fix cross join error and add more integration tests Nov 23, 2024
@Beyyes Beyyes changed the title Fix cross join error and add more integration tests Fix multi table joins error and add more integration tests Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant