kie-issues#1613: Add `CI :: License headers` GitHub Actions workflow #3714

jomarko · 2024-10-10T10:35:14Z

Is a partial fix of the apache/incubator-kie-issues#1613 where we submit one PR per repository.

Closes/Fixes/Resolves #ISSUE-NUMBER

Description:

Please make sure that your PR meets the following requirements:

You have read the contributors guide
Your code is properly formatted according to this configuration
Pull Request title is properly formatted: Issue-XYZ Subject
Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
Pull Request contains link to the JIRA issue
Pull Request contains link to any dependent or related Pull Request
Pull Request contains description of the issue
Pull Request does not include fixes for issues other than the main ticket

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

yesamer · 2024-10-10T12:35:56Z

jbpm/jbpm-bpmn2/src/main/resources/META-INF/BPMN20.xsd

@@ -1,4 +1,22 @@
 <?xml version="1.0" encoding="UTF-8"?>
+<!--


@jomarko Not sure we can add the Apache license in the BMPN and DMN xsd files and related..., that because those are generated by OMG, therefore those should considered external assets, and not "ours".

This reverts commit 00cfcc5.

jomarko · 2024-10-11T05:27:42Z

Failed test:

2024-10-10T19:08:00.2886599Z [ERROR] Tests run: 49, Failures: 1, Errors: 0, Skipped: 5, Time elapsed: 5.927 s <<< FAILURE! -- in org.jbpm.bpmn2.StandaloneBPMNProcessTest
2024-10-10T19:08:00.2888692Z [ERROR] org.jbpm.bpmn2.StandaloneBPMNProcessTest.testEventBasedSplit2 -- Time elapsed: 0.531 s <<< FAILURE!
2024-10-10T19:08:00.2890152Z org.opentest4j.AssertionFailedError: 
2024-10-10T19:08:00.2890583Z 
2024-10-10T19:08:00.2890733Z expected: 2
2024-10-10T19:08:00.2891102Z  but was: 1
2024-10-10T19:08:00.2891989Z 	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
2024-10-10T19:08:00.2893744Z 	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
2024-10-10T19:08:00.2895699Z 	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
2024-10-10T19:08:00.2897403Z 	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
2024-10-10T19:08:00.2898780Z 	at org.jbpm.bpmn2.StandaloneBPMNProcessTest.testEventBasedSplit2(StandaloneBPMNProcessTest.java:407)
2024-10-10T19:08:00.2900004Z 	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
2024-10-10T19:08:00.2900922Z 	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2024-10-10T19:08:00.2901884Z 	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

kie-ci3 · 2024-10-11T09:26:17Z

PR job #3 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3714 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3714/3/display/redirect

Test results:

PASSED: 3369
FAILED: 1

Those are the test failures:

org.jbpm.bpmn2.IntermediateEventTest.testEventBasedSplit2

expected: 2
but was: 1

jomarko · 2024-10-11T13:36:40Z

Running locally mvn clean install -Dfull -Prun-code-coverage -Dtest=IntermediateEventTest does not reproduce the test failure.

yesamer

LGTM, just make sure the builds are green (disregarding flaky tests)

jomarko · 2024-11-14T12:29:00Z

This will be addressed via apache/incubator-kie-issues#1613

tkobayas · 2024-11-15T02:25:15Z

@jomarko You may not need to close this PR? Rather, this PR can link to apache/incubator-kie-issues#1613 and:

Add license headers where needed (this PR so far is valid)
Add .rat-excludes for ignorable files
Hopefully add a GHA for rat check
Remove apache-rat-plugin and checkstyle.header.template

WDYT? (or you may have another plan?)

jomarko · 2024-11-15T06:14:03Z

@tkobayas ok, I can reopen the PR, I just thought it will be better to start with fresh PR, as this PR is kind of old, but you are probably right, I can update it.

jomarko · 2024-11-15T10:23:04Z

LICENSE

+------------------------------------------------------------------------------------
+This product bundles various third-party components under other open source licenses.
+This section summarizes those components and their licenses. See licenses/
+for text of these licenses.
+
+OMG BPMN Specification License (https://www.omg.org/spec/BPMN)
+--------------------------------------------------------------
+jbpm/jbpm-bpmn2/src/main/resources/META-INF/BPMN20.xsd
+jbpm/jbpm-bpmn2/src/main/resources/META-INF/BPMNDI.xsd
+jbpm/jbpm-bpmn2/src/main/resources/META-INF/DC.xsd
+jbpm/jbpm-bpmn2/src/main/resources/META-INF/DI.xsd
+jbpm/jbpm-bpmn2/src/main/resources/META-INF/Semantic.xsd


Here I need your help and proposals team. How would you proceed? I struggle to find LICENSE/NOTICE information for given files.

Hi @jomarko , I found that BPMN 2.0 spec PDF contains "LICENSE" section. https://www.omg.org/spec/BPMN/2.0/PDF It's better to double-check with jBPM team @krisv @fjtirado

Btw, see my PR updates, IPMC prefers adding all LICENSE texts in single LICENSE file rather than having them under licenses directory. apache/incubator-kie-drools#6153

thank you, I have deleted the licenses folder, however, the actual license text is still a question, I do not think it is actually something from the PDF.

Currently @porcelli and @LightGuard is looking into it.

Pushed the "LICENSES" part from the PDF, anyone who knows what parts from the PDF should be copied into LICENSE file, please share your knowledge.

tkobayas · 2024-11-21T06:28:13Z

LICENSE

+    jbpm/jbpm-bpmn2/src/main/resources/META-INF/DI.xsd
+    jbpm/jbpm-bpmn2/src/main/resources/META-INF/Semantic.xsd
+
+TODO put license text for files listed above here.


I don't know when https://issues.apache.org/jira/browse/LEGAL-690 will be answered, but I hope it wouldn't be a blocker for 10.0.0 release. At least for this PR, I think you can keep the "TODO", or align with drools main (https://github.com/apache/incubator-kie-drools/blob/main/LICENSE#L248-L382 , note that it was taken from DMN spec, this PR needs to take from BPMN spec). @porcelli thoughts?

…/test/resources

tkobayas · 2024-11-25T05:13:55Z

.rat-excludes

+# jbpm/jbpm-tests/src/test/bpmn/org/jbpm/bpmn2/activity/BPMN2-BoundarySignalEventOnTaskWithTransformation.bpmn
+BPMN2-BoundarySignalEventOnTaskWithTransformation.bpmn


I think we can add license headers to .bpmn and .bpmn2. We may do it in another PR though.

tkobayas

Thank you, @jomarko !

jomarko · 2024-11-25T10:50:49Z

@tkobayas hi, I added bpmn[2] files licenses as part of this PR.

kie-ci3 · 2024-11-25T15:27:59Z

PR job #17 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3714 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3714/17/display/redirect

Test results:

PASSED: 3480
FAILED: 1

Those are the test failures:

org.kie.kogito.codegen.rules.PublishEventBusinessRuleIT.testBusinessRuleProcessStartToEndWithVariableTracked

Expected size: 10 but was: 21 in:
[ProcessInstanceStateDataEvent {specVersion=1.0, id='8b3a09d4-a177-47a7-87ba-9e3bf70b25a6', source=http://myhost/TimerProcess, type='ProcessInstanceStateDataEvent', time=2024-11-25T06:34:22.968651287-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceStateEventBody [eventDate=Mon Nov 25 06:34:22 EST 2024, eventUser=null, eventType=1, processId=defaultPackage.TimerProcess, processVersion=1.0, processType=BPMN, processInstanceId=09893a9e-0285-4bea-bd22-c6e028185853, businessKey=null, processName=TimerProcess, parentInstanceId=null, rootProcessId=null, rootProcessInstanceId=null, state=1, roles=null], kogitoProcessInstanceId='09893a9e-0285-4bea-bd22-c6e028185853', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=09893a9e-0285-4bea-bd22-c6e028185853, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test}},
ProcessInstanceNodeDataEvent {specVersion=1.0, id='22072e78-99ef-4b70-b205-a3df2ecb9721', source=http://myhost/TimerProcess, type='ProcessInstanceNodeDataEvent', time=2024-11-25T06:34:22.961523326-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Mon Nov 25 06:34:22 EST 2024, eventUser=null, eventType=1, processId=defaultPackage.TimerProcess, processVersion=1.0, processInstanceId=09893a9e-0285-4bea-bd22-c6e028185853, connectionNodeInstanceId=null, nodeDefinitionId=_F9AC8B12-8E75-49B5-B799-292F66270627, nodeName=start, nodeType=StartNode, nodeInstanceId=0b54496f-7244-4a5a-946e-b772bcd0d22f, data={}], kogitoProcessInstanceId='09893a9e-0285-4bea-bd22-c6e028185853', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=09893a9e-0285-4bea-bd22-c6e028185853, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test}},
ProcessInstanceNodeDataEvent {specVersion=1.0, id='cf9ef691-bbad-44a9-92c4-82357ee95cde', source=http://myhost/TimerProcess, type='ProcessInstanceNodeDataEvent', time=2024-11-25T06:34:22.961897104-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Mon Nov 25 06:34:22 EST 2024, eventUser=null, eventType=1, processId=defaultPackage.TimerProcess, processVersion=1.0, processInstanceId=09893a9e-0285-4bea-bd22-c6e028185853, connectionNodeInstanceId=SequenceFlow_2, nodeDefinitionId=_E76AD186-6FA6-4378-B45B-C8F73E2C497C, nodeName=timer fired, nodeType=ActionNode, nodeInstanceId=9427aa7f-3cc1-4107-8c3f-dbb687e02a27, data={}], kogitoProcessInstanceId='09893a9e-0285-4bea-bd22-c6e028185853', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=09893a9e-0285-4bea-bd22-c6e028185853, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test}},
ProcessInstanceNodeDataEvent {specVersion=1.0, id='6cc7cbbe-9d76-40d9-8d1d-08ccdb1122ef', source=http://myhost/TimerProcess, type='ProcessInstanceNodeDataEvent', time=2024-11-25T06:34:22.962411220-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Mon Nov 25 06:34:22 EST 2024, eventUser=null, eventType=1, processId=defaultPackage.TimerProcess, processVersion=1.0, processInstanceId=09893a9e-0285-4bea-bd22-c6e028185853, connectionNodeInstanceId=SequenceFlow_1, nodeDefinitionId=UserTask_1, nodeName=User Task 1, nodeType=HumanTaskNode, nodeInstanceId=b7a80c5d-9f16-4d17-b5b5-8eefc4e3ab68, data={}], kogitoProcessInstanceId='09893a9e-0285-4bea-bd22-c6e028185853', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=09893a9e-0285-4bea-bd22-c6e028185853, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test}},
UserTaskInstanceStateDataEvent {specVersion=1.0, id='951e2ed4-e39d-4d9a-9352-0d29f2aa5baa', source=/process/null, type='UserTaskInstanceStateDataEvent', time=2024-11-25T06:34:22.963643335-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=UserTaskInstanceStateEventBody [eventDate=Mon Nov 25 06:34:22 EST 2024, eventUser=null, userTaskDefinitionId=UserTask_1, userTaskInstanceId=930a2993-3a57-4dad-943b-f75fe47370d4, userTaskName=Task Name, userTaskDescription=null, userTaskPriority=1, userTaskReferenceName=User Task 1, state=Created, actualOwner=null, processInstanceId=null], kogitoProcessInstanceId='null', kogitoRootProcessInstanceId='null', kogitoProcessId='null', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitousertaskist=Created, kogitoprocrefid=User Task 1, kogitoprocist=null, kogitoaddons=test, kogitousertaskiid=930a2993-3a57-4dad-943b-f75fe47370d4}},
UserTaskInstanceStateDataEvent {specVersion=1.0, id='2fa7e826-4ac8-4dba-b4ff-45682412235f', source=/process/null, type='UserTaskInstanceStateDataEvent', time=2024-11-25T06:34:22.964048528-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=UserTaskInstanceStateEventBody [eventDate=Mon Nov 25 06:34:22 EST 2024, eventUser=null, userTaskDefinitionId=UserTask_1, userTaskInstanceId=930a2993-3a57-4dad-943b-f75fe47370d4, userTaskName=Task Name, userTaskDescription=null, userTaskPriority=1, userTaskReferenceName=User Task 1, state=Created, actualOwner=null, processInstanceId=null], kogitoProcessInstanceId='null', kogitoRootProcessInstanceId='null', kogitoProcessId='null', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitousertaskist=Created, kogitoprocrefid=User Task 1, kogitoprocist=null, kogitoaddons=test, kogitousertaskiid=930a2993-3a57-4dad-943b-f75fe47370d4}},
UserTaskInstanceStateDataEvent {specVersion=1.0, id='0c1a9515-5a7b-43fb-b375-ea992183422c', source=/process/null, type='UserTaskInstanceStateDataEvent', time=2024-11-25T06:34:22.964405746-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=UserTaskInstanceStateEventBody [eventDate=Mon Nov 25 06:34:22 EST 2024, eventUser=null, userTaskDefinitionId=UserTask_1, userTaskInstanceId=930a2993-3a57-4dad-943b-f75fe47370d4, userTaskName=Task Name, userTaskDescription=null, userTaskPriority=1, userTaskReferenceName=User Task 1, state=Created, actualOwner=null, processInstanceId=null], kogitoProcessInstanceId='null', kogitoRootProcessInstanceId='null', kogitoProcessId='null', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitousertaskist=Created, kogitoprocrefid=User Task 1, kogitoprocist=null, kogitoaddons=test, kogitousertaskiid=930a2993-3a57-4dad-943b-f75fe47370d4}},
UserTaskInstanceStateDataEvent {specVersion=1.0, id='912ad175-1a58-420a-9e3b-42661ab14860', source=http://myhost/TimerProcess, type='UserTaskInstanceStateDataEvent', time=2024-11-25T06:34:22.966321523-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=UserTaskInstanceStateEventBody [eventDate=Mon Nov 25 06:34:22 EST 2024, eventUser=null, userTaskDefinitionId=UserTask_1, userTaskInstanceId=930a2993-3a57-4dad-943b-f75fe47370d4, userTaskName=Task Name, userTaskDescription=null, userTaskPriority=1, userTaskReferenceName=User Task 1, state=Created, actualOwner=null, processInstanceId=09893a9e-0285-4bea-bd22-c6e028185853], kogitoProcessInstanceId='09893a9e-0285-4bea-bd22-c6e028185853', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitousertaskist=Created, kogitoprocrefid=User Task 1, kogitoproctype=BPMN, kogitoprocinstanceid=09893a9e-0285-4bea-bd22-c6e028185853, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test, kogitousertaskiid=930a2993-3a57-4dad-943b-f75fe47370d4}},
UserTaskInstanceStateDataEvent {specVersion=1.0, id='3c67d7e7-6b69-45d7-9f55-e479057e6e2e', source=http://myhost/TimerProcess, type='UserTaskInstanceStateDataEvent', time=2024-11-25T06:34:22.967515106-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=UserTaskInstanceStateEventBody [eventDate=Mon Nov 25 06:34:22 EST 2024, eventUser=null, userTaskDefinitionId=UserTask_1, userTaskInstanceId=930a2993-3a57-4dad-943b-f75fe47370d4, userTaskName=Task Name, userTaskDescription=null, userTaskPriority=1, userTaskReferenceName=User Task 1, state=Ready, actualOwner=null, processInstanceId=09893a9e-0285-4bea-bd22-c6e028185853], kogitoProcessInstanceId='09893a9e-0285-4bea-bd22-c6e028185853', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitousertaskist=Ready, kogitoprocrefid=User Task 1, kogitoproctype=BPMN, kogitoprocinstanceid=09893a9e-0285-4bea-bd22-c6e028185853, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test, kogitousertaskiid=930a2993-3a57-4dad-943b-f75fe47370d4}},
ProcessInstanceNodeDataEvent {specVersion=1.0, id='d8964cb0-8f3e-4876-afda-df7492c65758', source=http://myhost/TimerProcess, type='ProcessInstanceNodeDataEvent', time=2024-11-25T06:34:22.968134122-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Mon Nov 25 06:34:22 EST 2024, eventUser=null, eventType=2, processId=defaultPackage.TimerProcess, processVersion=1.0, processInstanceId=09893a9e-0285-4bea-bd22-c6e028185853, connectionNodeInstanceId=SequenceFlow_1, nodeDefinitionId=_E76AD186-6FA6-4378-B45B-C8F73E2C497C, nodeName=timer fired, nodeType=ActionNode, nodeInstanceId=9427aa7f-3cc1-4107-8c3f-dbb687e02a27, data={}], kogitoProcessInstanceId='09893a9e-0285-4bea-bd22-c6e028185853', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=09893a9e-0285-4bea-bd22-c6e028185853, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test}},
ProcessInstanceNodeDataEvent {specVersion=1.0, id='bc801768-705a-4881-b95f-a4a0950872fe', source=http://myhost/TimerProcess, type='ProcessInstanceNodeDataEvent', time=2024-11-25T06:34:22.968410005-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Mon Nov 25 06:34:22 EST 2024, eventUser=null, eventType=2, processId=defaultPackage.TimerProcess, processVersion=1.0, processInstanceId=09893a9e-0285-4bea-bd22-c6e028185853, connectionNodeInstanceId=SequenceFlow_2, nodeDefinitionId=_F9AC8B12-8E75-49B5-B799-292F66270627, nodeName=start, nodeType=StartNode, nodeInstanceId=0b54496f-7244-4a5a-946e-b772bcd0d22f, data={}], kogitoProcessInstanceId='09893a9e-0285-4bea-bd22-c6e028185853', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=09893a9e-0285-4bea-bd22-c6e028185853, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test}},
ProcessInstanceStateDataEvent {specVersion=1.0, id='211386ac-deec-4f26-9ad5-faf4ffe352a6', source=http://myhost/BusinessRuleTask, type='ProcessInstanceStateDataEvent', time=2024-11-25T06:34:23.038283376-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceStateEventBody [eventDate=Mon Nov 25 06:34:23 EST 2024, eventUser=null, eventType=1, processId=BusinessRuleTask, processVersion=1, processType=BPMN, processInstanceId=f446ee63-0442-46b1-9361-54484462be6d, businessKey=null, processName=Default Process, parentInstanceId=null, rootProcessId=null, rootProcessInstanceId=null, state=2, roles=null], kogitoProcessInstanceId='f446ee63-0442-46b1-9361-54484462be6d', kogitoRootProcessInstanceId='null', kogitoProcessId='BusinessRuleTask', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=f446ee63-0442-46b1-9361-54484462be6d, kogitoprocist=2, kogitoprocversion=1, kogitoprocid=BusinessRuleTask, kogitoaddons=test}},
ProcessInstanceVariableDataEvent {specVersion=1.0, id='66dfe453-2bd6-4634-bdc5-5fb13fa10544', source=http://myhost/BusinessRuleTask, type='ProcessInstanceVariableDataEvent', time=2024-11-25T06:34:22.324957675-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceVariableEventBody [eventDate=Mon Nov 25 06:34:22 EST 2024, eventUser=null, processId=BusinessRuleTask, processVersion=1, processInstanceId=f446ee63-0442-46b1-9361-54484462be6d, nodeContainerDefinitionId=null, nodeContainerInstanceId=null, variableId=person, variableName=person, variableValue=Person{name='john', age=25, adult=true}], kogitoProcessInstanceId='f446ee63-0442-46b1-9361-54484462be6d', kogitoRootProcessInstanceId='null', kogitoProcessId='BusinessRuleTask', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=f446ee63-0442-46b1-9361-54484462be6d, kogitoprocist=0, kogitoprocversion=1, kogitoprocid=BusinessRuleTask, kogitoaddons=test}},
ProcessInstanceNodeDataEvent {specVersion=1.0, id='95e9edd7-78b4-411a-a0b3-a11831880772', source=http://myhost/BusinessRuleTask, type='ProcessInstanceNodeDataEvent', time=2024-11-25T06:34:22.325554475-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Mon Nov 25 06:34:22 EST 2024, eventUser=null, eventType=1, processId=BusinessRuleTask, processVersion=1, processInstanceId=f446ee63-0442-46b1-9361-54484462be6d, connectionNodeInstanceId=null, nodeDefinitionId=StartEvent_1, nodeName=Start, nodeType=StartNode, nodeInstanceId=af273361-8d4c-4236-986c-b9143e22d027, data={}], kogitoProcessInstanceId='f446ee63-0442-46b1-9361-54484462be6d', kogitoRootProcessInstanceId='null', kogitoProcessId='BusinessRuleTask', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=f446ee63-0442-46b1-9361-54484462be6d, kogitoprocist=1, kogitoprocversion=1, kogitoprocid=BusinessRuleTask, kogitoaddons=test}},
ProcessInstanceNodeDataEvent {specVersion=1.0, id='0a2a9ede-388c-4d23-9157-2c75ee21f8d1', source=http://myhost/BusinessRuleTask, type='ProcessInstanceNodeDataEvent', time=2024-11-25T06:34:22.325961103-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Mon Nov 25 06:34:22 EST 2024, eventUser=null, eventType=1, processId=BusinessRuleTask, processVersion=1, processInstanceId=f446ee63-0442-46b1-9361-54484462be6d, connectionNodeInstanceId=SequenceFlow_2, nodeDefinitionId=BusinessRuleTask_2, nodeName=Business Rule Task, nodeType=RuleSetNode, nodeInstanceId=cc39bf50-325e-43f5-8c43-867035267595, data={}], kogitoProcessInstanceId='f446ee63-0442-46b1-9361-54484462be6d', kogitoRootProcessInstanceId='null', kogitoProcessId='BusinessRuleTask', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=f446ee63-0442-46b1-9361-54484462be6d, kogitoprocist=1, kogitoprocversion=1, kogitoprocid=BusinessRuleTask, kogitoaddons=test}},
ProcessInstanceVariableDataEvent {specVersion=1.0, id='eb81dd4d-3818-4516-a6fd-1ce8caf1f668', source=http://myhost/BusinessRuleTask, type='ProcessInstanceVariableDataEvent', time=2024-11-25T06:34:23.026808965-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceVariableEventBody [eventDate=Mon Nov 25 06:34:23 EST 2024, eventUser=null, processId=BusinessRuleTask, processVersion=1, processInstanceId=f446ee63-0442-46b1-9361-54484462be6d, nodeContainerDefinitionId=null, nodeContainerInstanceId=null, variableId=person, variableName=person, variableValue=Person{name='john', age=25, adult=true}], kogitoProcessInstanceId='f446ee63-0442-46b1-9361-54484462be6d', kogitoRootProcessInstanceId='null', kogitoProcessId='BusinessRuleTask', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=f446ee63-0442-46b1-9361-54484462be6d, kogitoprocist=1, kogitoprocversion=1, kogitoprocid=BusinessRuleTask, kogitoaddons=test}},
ProcessInstanceNodeDataEvent {specVersion=1.0, id='42277e9b-6886-46ce-b4aa-ad0ae631cb9a', source=http://myhost/BusinessRuleTask, type='ProcessInstanceNodeDataEvent', time=2024-11-25T06:34:23.027392395-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Mon Nov 25 06:34:23 EST 2024, eventUser=null, eventType=1, processId=BusinessRuleTask, processVersion=1, processInstanceId=f446ee63-0442-46b1-9361-54484462be6d, connectionNodeInstanceId=SequenceFlow_1, nodeDefinitionId=EndEvent_1, nodeName=End, nodeType=EndNode, nodeInstanceId=93bab3ee-1432-480e-bf5b-868f0b8348ac, data={}], kogitoProcessInstanceId='f446ee63-0442-46b1-9361-54484462be6d', kogitoRootProcessInstanceId='null', kogitoProcessId='BusinessRuleTask', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=f446ee63-0442-46b1-9361-54484462be6d, kogitoprocist=1, kogitoprocversion=1, kogitoprocid=BusinessRuleTask, kogitoaddons=test}},
ProcessInstanceNodeDataEvent {specVersion=1.0, id='6fee66b5-1770-4768-8b2c-c183b1bc0280', source=http://myhost/BusinessRuleTask, type='ProcessInstanceNodeDataEvent', time=2024-11-25T06:34:23.034902474-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Mon Nov 25 06:34:23 EST 2024, eventUser=null, eventType=2, processId=BusinessRuleTask, processVersion=1, processInstanceId=f446ee63-0442-46b1-9361-54484462be6d, connectionNodeInstanceId=null, nodeDefinitionId=EndEvent_1, nodeName=End, nodeType=EndNode, nodeInstanceId=93bab3ee-1432-480e-bf5b-868f0b8348ac, data={}], kogitoProcessInstanceId='f446ee63-0442-46b1-9361-54484462be6d', kogitoRootProcessInstanceId='null', kogitoProcessId='BusinessRuleTask', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=f446ee63-0442-46b1-9361-54484462be6d, kogitoprocist=2, kogitoprocversion=1, kogitoprocid=BusinessRuleTask, kogitoaddons=test}},
ProcessInstanceNodeDataEvent {specVersion=1.0, id='2af6728e-fd00-4a7e-9490-97f71e17df81', source=http://myhost/BusinessRuleTask, type='ProcessInstanceNodeDataEvent', time=2024-11-25T06:34:23.035124377-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Mon Nov 25 06:34:23 EST 2024, eventUser=null, eventType=2, processId=BusinessRuleTask, processVersion=1, processInstanceId=f446ee63-0442-46b1-9361-54484462be6d, connectionNodeInstanceId=SequenceFlow_1, nodeDefinitionId=BusinessRuleTask_2, nodeName=Business Rule Task, nodeType=RuleSetNode, nodeInstanceId=cc39bf50-325e-43f5-8c43-867035267595, data={}], kogitoProcessInstanceId='f446ee63-0442-46b1-9361-54484462be6d', kogitoRootProcessInstanceId='null', kogitoProcessId='BusinessRuleTask', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=f446ee63-0442-46b1-9361-54484462be6d, kogitoprocist=2, kogitoprocversion=1, kogitoprocid=BusinessRuleTask, kogitoaddons=test}},
ProcessInstanceNodeDataEvent {specVersion=1.0, id='e672ca04-a0f6-4dac-8224-bb2b5d3d01d3', source=http://myhost/BusinessRuleTask, type='ProcessInstanceNodeDataEvent', time=2024-11-25T06:34:23.038001651-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Mon Nov 25 06:34:23 EST 2024, eventUser=null, eventType=2, processId=BusinessRuleTask, processVersion=1, processInstanceId=f446ee63-0442-46b1-9361-54484462be6d, connectionNodeInstanceId=SequenceFlow_2, nodeDefinitionId=StartEvent_1, nodeName=Start, nodeType=StartNode, nodeInstanceId=af273361-8d4c-4236-986c-b9143e22d027, data={}], kogitoProcessInstanceId='f446ee63-0442-46b1-9361-54484462be6d', kogitoRootProcessInstanceId='null', kogitoProcessId='BusinessRuleTask', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=f446ee63-0442-46b1-9361-54484462be6d, kogitoprocist=2, kogitoprocversion=1, kogitoprocid=BusinessRuleTask, kogitoaddons=test}},
ProcessInstanceStateDataEvent {specVersion=1.0, id='a470e731-dee1-4dac-bc4f-391bf5e63f39', source=http://myhost/BusinessRuleTask, type='ProcessInstanceStateDataEvent', time=2024-11-25T06:34:23.034615742-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceStateEventBody [eventDate=Mon Nov 25 06:34:23 EST 2024, eventUser=null, eventType=2, processId=BusinessRuleTask, processVersion=1, processType=BPMN, processInstanceId=f446ee63-0442-46b1-9361-54484462be6d, businessKey=null, processName=Default Process, parentInstanceId=null, rootProcessId=null, rootProcessInstanceId=null, state=2, roles=null], kogitoProcessInstanceId='f446ee63-0442-46b1-9361-54484462be6d', kogitoRootProcessInstanceId='null', kogitoProcessId='BusinessRuleTask', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=f446ee63-0442-46b1-9361-54484462be6d, kogitoprocist=2, kogitoprocversion=1, kogitoprocid=BusinessRuleTask, kogitoaddons=test}}]

LightGuard · 2024-11-25T19:23:40Z

@pjfanning and @chrisdutz it would be good to get your feedback on this as we progress towards RC4

tkobayas · 2024-11-27T08:36:55Z

I approve this PR as the basis of NOTICE, LICENSE and rat-exclude is done. We can continue the work with new PRs, so we can focus on high priority issues (= "Category X or Category B" license) first.

tkobayas · 2024-11-29T01:39:27Z

@jomarko We got 2 approvals. I think you can merge this when you are comfortable.

…pache#3714) * Add license header * Revert "Add license header" This reverts commit 00cfcc5. * Add license header * revert beans.xml * .rat-excludes and rat check action * remove checkstyle.header.template * OMG BPMN SPEC files license * .rat-excludes fix format - escaping * .rat-excludes * storage-jpa license * apache rat 17 * fix exit logic * print rat check output * align with other PRs of kie-issues#1613 * license text placeholder * LICENSE SPEC * Revert "LICENSE SPEC" This reverts commit 3e4e2f8. * List explicitely all files in the .rat-excludes * Use apache-rat v0.16.1 * Everthing -> Everything * BPMN LICENSE text * CI :: License headers * kogito-codegen-modules/kogito-codegen-processes-integration-tests/src/test/resources * .bpmn[2] files

Add license header

00cfcc5

yesamer reviewed Oct 10, 2024

View reviewed changes

jomarko added 2 commits October 10, 2024 20:54

Revert "Add license header"

eb60175

This reverts commit 00cfcc5.

Add license header

5727aeb

revert beans.xml

2dd019c

yesamer approved these changes Oct 14, 2024

View reviewed changes

jomarko closed this Nov 14, 2024

jomarko reopened this Nov 15, 2024

jomarko changed the title ~~NO-ISSUE: Add license header~~ kie-issues#1613: Add license header Nov 15, 2024

jomarko added 3 commits November 15, 2024 07:17

Merge branch 'main' into runtimes-license

012973d

.rat-excludes and rat check action

a83d727

remove checkstyle.header.template

1361fed

yesamer linked an issue Nov 15, 2024 that may be closed by this pull request

Add .rat-excludes file to each repository apache/incubator-kie-issues#1613

Open

11 tasks

jomarko added 6 commits November 15, 2024 08:52

OMG BPMN SPEC files license

8ac99a2

.rat-excludes fix format - escaping

ab721ea

.rat-excludes

360aa1e

storage-jpa license

bcd348d

apache rat 17

906228d

fix exit logic

f4d6031

jomarko requested review from yesamer and tkobayas November 15, 2024 10:21

jomarko commented Nov 15, 2024

View reviewed changes

jomarko mentioned this pull request Nov 15, 2024

Add .rat-excludes file to each repository apache/incubator-kie-issues#1613

Open

11 tasks

print rat check output

ee0d2e9

tkobayas mentioned this pull request Nov 19, 2024

adding OMG XSD files License info apache/incubator-kie-drools#6156

Merged

tkobayas requested a review from porcelli November 20, 2024 03:35

tkobayas reviewed Nov 21, 2024

View reviewed changes

jomarko added 4 commits November 21, 2024 13:46

List explicitely all files in the .rat-excludes

0a6bcaa

Use apache-rat v0.16.1

8e0651d

Everthing -> Everything

62e9a72

BPMN LICENSE text

b78016f

jomarko added the Do not merge label Nov 21, 2024

jomarko changed the title ~~kie-issues#1613: Add CI :: Check license headers GitHub Actions workflow~~ [DO NOT MERGE][WORK IN PROGRESS]kie-issues#1613: Add CI :: Check license headers GitHub Actions workflow Nov 21, 2024

jomarko added 3 commits November 22, 2024 05:53

Merge branch 'main' into runtimes-license

4780813

CI :: License headers

a217085

kogito-codegen-modules/kogito-codegen-processes-integration-tests/src…

d0e2f80

…/test/resources

jomarko changed the title ~~[DO NOT MERGE][WORK IN PROGRESS]kie-issues#1613: Add CI :: Check license headers GitHub Actions workflow~~ kie-issues#1613: Add CI :: License headers GitHub Actions workflow Nov 22, 2024

jomarko removed the Do not merge label Nov 22, 2024

tkobayas reviewed Nov 25, 2024

View reviewed changes

tkobayas approved these changes Nov 25, 2024

View reviewed changes

.bpmn[2] files

e376fd9

yesamer approved these changes Nov 25, 2024

View reviewed changes

This was referenced Nov 26, 2024

EPIC - Issues found during Apache KIE 10.0.0 release candidates verification/votes apache/incubator-kie-issues#1525

Open

Review "3rd party Category X or Category B bundled code licenses not listed in LICENSE" for 10.0.0 apache/incubator-kie-issues#1634

Open

Merge branch 'main' into runtimes-license

a6cac6b

tkobayas mentioned this pull request Nov 27, 2024

notice file for drools is not correct apache/incubator-kie-issues#1616

Closed

jomarko merged commit 5dd444e into apache:main Nov 29, 2024
7 checks passed

jomarko mentioned this pull request Nov 29, 2024

[10.0.x] kie-issues#1613: Add CI :: License headers GitHub Actions workflow #3797

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kie-issues#1613: Add `CI :: License headers` GitHub Actions workflow #3714

kie-issues#1613: Add `CI :: License headers` GitHub Actions workflow #3714

jomarko commented Oct 10, 2024 •

edited

Loading

yesamer Oct 10, 2024

jomarko Oct 10, 2024

jomarko commented Oct 11, 2024

kie-ci3 commented Oct 11, 2024

jomarko commented Oct 11, 2024

yesamer left a comment •

edited

Loading

jomarko commented Nov 14, 2024

tkobayas commented Nov 15, 2024 •

edited

Loading

jomarko commented Nov 15, 2024

jomarko Nov 15, 2024

tkobayas Nov 18, 2024

jomarko Nov 18, 2024

jomarko Nov 18, 2024

tkobayas Nov 21, 2024 •

edited

Loading

tkobayas Nov 25, 2024 •

edited

Loading

tkobayas left a comment

jomarko commented Nov 25, 2024

kie-ci3 commented Nov 25, 2024

LightGuard commented Nov 25, 2024 •

edited by jomarko

Loading

tkobayas commented Nov 27, 2024

tkobayas commented Nov 29, 2024

		# jbpm/jbpm-tests/src/test/bpmn/org/jbpm/bpmn2/activity/BPMN2-BoundarySignalEventOnTaskWithTransformation.bpmn
		BPMN2-BoundarySignalEventOnTaskWithTransformation.bpmn

kie-issues#1613: Add CI :: License headers GitHub Actions workflow #3714

kie-issues#1613: Add CI :: License headers GitHub Actions workflow #3714

Conversation

jomarko commented Oct 10, 2024 • edited Loading

yesamer Oct 10, 2024

Choose a reason for hiding this comment

jomarko Oct 10, 2024

Choose a reason for hiding this comment

jomarko commented Oct 11, 2024

kie-ci3 commented Oct 11, 2024

jomarko commented Oct 11, 2024

yesamer left a comment • edited Loading

Choose a reason for hiding this comment

jomarko commented Nov 14, 2024

tkobayas commented Nov 15, 2024 • edited Loading

jomarko commented Nov 15, 2024

jomarko Nov 15, 2024

Choose a reason for hiding this comment

tkobayas Nov 18, 2024

Choose a reason for hiding this comment

jomarko Nov 18, 2024

Choose a reason for hiding this comment

jomarko Nov 18, 2024

Choose a reason for hiding this comment

tkobayas Nov 21, 2024 • edited Loading

Choose a reason for hiding this comment

tkobayas Nov 25, 2024 • edited Loading

Choose a reason for hiding this comment

tkobayas left a comment

Choose a reason for hiding this comment

jomarko commented Nov 25, 2024

kie-ci3 commented Nov 25, 2024

LightGuard commented Nov 25, 2024 • edited by jomarko Loading

tkobayas commented Nov 27, 2024

tkobayas commented Nov 29, 2024

kie-issues#1613: Add `CI :: License headers` GitHub Actions workflow #3714

kie-issues#1613: Add `CI :: License headers` GitHub Actions workflow #3714

jomarko commented Oct 10, 2024 •

edited

Loading

yesamer left a comment •

edited

Loading

tkobayas commented Nov 15, 2024 •

edited

Loading

tkobayas Nov 21, 2024 •

edited

Loading

tkobayas Nov 25, 2024 •

edited

Loading

LightGuard commented Nov 25, 2024 •

edited by jomarko

Loading