Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOP-4510: Fix Move Files action error on Windows #4582

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

wAVeckx
Copy link
Contributor

@wAVeckx wAVeckx commented Nov 18, 2024

This pull request is meant to fix the movefiles action


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@hansva
Copy link
Contributor

hansva commented Nov 18, 2024

I would have to dig in the code and check...
But It seems that the "else" block should just be removed from that if/elseif block.
Except for the Azure types all other files should just be handled like the used to be handled.

@hansva hansva self-assigned this Nov 18, 2024
@wAVeckx
Copy link
Contributor Author

wAVeckx commented Nov 18, 2024

I originally thought of doing that but assumed there was a reason for it being added in recently. Would you like me to adjust the code in the PR for this?

@hansva
Copy link
Contributor

hansva commented Nov 18, 2024

Yes please, feel free to do so. Thanks for the PR @wAVeckx !

@wAVeckx
Copy link
Contributor Author

wAVeckx commented Nov 18, 2024

Let me know if you have any further adjustment you would like to see made with this PR.

@hansva hansva merged commit 014598b into apache:main Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants