Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Write to log (transform) - Unable to select specified fields to log #4577

Closed
dave-csc opened this issue Nov 18, 2024 · 4 comments
Closed
Assignees
Milestone

Comments

@dave-csc
Copy link
Contributor

Apache Hop version?

2.10.0

Java version?

17.0.2

Operating system

Linux

What happened?

Add a Write to log transform in a pipeline.

In version 2.10.0, you cannot specify directly the fields you want to log, unless you press the button Get fields and then remove the unnecessary ones.

In version 2.9.0, you can choose the fields you want to log without workarounds.

Marked as P1 for regression

Issue Priority

Priority: 1

Issue Component

Component: Hop Gui, Component: Transforms

@bamaer
Copy link
Contributor

bamaer commented Nov 18, 2024

.take-issue

@shlxue
Copy link
Contributor

shlxue commented Nov 20, 2024

Maybe it should be updated itemCount in TableView.removeAll method.

@hansva
Copy link
Contributor

hansva commented Nov 20, 2024

I'll review both fixes because now we have 2 PR's for this issue.

@shlxue
Copy link
Contributor

shlxue commented Nov 20, 2024

😄. When automatically appending an empty row as the default behavior of tableview: the tableview must keep the itemcount & count of TableItem consistent.

Normal:

  1. create tableview ui
  2. Init columns(sync or async)
  3. in getData method
    3.1 remove all
    3.2 append rows(if 0 row? --> itemcount is 0 --> non edit mode)
  4. SetRowNum(must be active edit mode if 0 row)
  5. optWidth

@hansva hansva closed this as completed in 8f84e87 Nov 21, 2024
hansva added a commit that referenced this issue Nov 21, 2024
remove remove all rows from fields table. fixes #4577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants