Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hop server enhancement #4569 #4574

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Hop server enhancement #4569 #4574

wants to merge 1 commit into from

Conversation

nadment
Copy link
Contributor

@nadment nadment commented Nov 15, 2024

  • add command line options for (host, port, shutdownport, proxyhost, proxyport,ssl)
  • support for override properties on the command line
  • add shutdown listener to web server
  • add shutdown servlet
  • add RemoteHopServer class to interact with a Hop server and clean HopServerMeta
  • remove setup hop server syntax by hostname and port
  • add HopServerTerminate extension point after shutdown
  • all HopServerXXX extension points now provide a HopServer object, rather than a HopServer/WebServer mix
  • add command line options --help and --version
  • set abbreviateSynopsis and usageHelpAutoWidth to command line

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@nadment nadment linked an issue Nov 15, 2024 that may be closed by this pull request
- add command line options for (host, port, shutdownport, proxyhost,
proxyport,ssl)
- support for override properties on the command line
- add shutdown listener to web server
- add shutdown servlet
- add RemoteHopServer class to interact with a Hop server and clean
HopServerMeta
- remove setup hop server syntax by hostname and port
- add HopServerTerminate extension point after shutdown
- all HopServerXXX extension points now provide a HopServer object,
rather than a HopServer/WebServer mix
- Set abbreviateSynopsis and usageHelpAutoWidth to command line
@bamaer
Copy link
Contributor

bamaer commented Nov 24, 2024

we need better option grouping, port appears as sub-option of password, host appears as sub-option of help etc:

  -h, --help              Displays this help message and quits.
      --host=<host>       The server host name or IP address to use.
  -p, --password=<password>
                          The server password. Required for administrative operations only, not for starting the server.
      --port=<port>       The server port to use.

@bamaer
Copy link
Contributor

bamaer commented Nov 24, 2024

tested:

  • additional options for host, port, username, password,
  • -v and -h options
  • shutdown/kill only works when correct authentication is provided
  • --ssl options doesn't seem to work

@nadment
Copy link
Contributor Author

nadment commented Nov 24, 2024

For option grouping, this is the behavior of Picoli if we do not define a unique letter for an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Hop server enhancement
2 participants